Bug 1744719 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Here is the stack trace for https://boring-easley-d4cbde.netlify.app/:
```
xul!mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint + 0x2b0   
xul!mozilla::CycleCollectedJSContext::LeaveMicroTask + 0x13   
xul!mozilla::nsAutoMicroTask::~nsAutoMicroTask + 0x1d   
xul!mozilla::EventListenerManager::HandleEventSubType + 0x1ee   
xul!mozilla::EventListenerManager::HandleEventInternal + 0x4e6   
xul!mozilla::EventListenerManager::HandleEvent + 0x8d   
xul!mozilla::EventTargetChainItem::HandleEvent + 0x29c   
xul!mozilla::EventTargetChainItem::HandleEventTargetChain + 0x485   
xul!mozilla::EventDispatcher::Dispatch + 0xfe5   
xul!mozilla::EventDispatcher::DispatchDOMEvent + 0xf7   
xul!mozilla::DOMEventTargetHelper::DispatchEvent + 0x45   
xul!mozilla::dom::EventTarget::DispatchEvent + 0x34   
xul!mozilla::dom::MessageEventRunnable::DispatchDOMEvent + 0x4b2   
xul!mozilla::dom::MessageEventRunnable::WorkerRun + 0x74   
xul!mozilla::dom::WorkerRunnable::Run + 0x2b9   
xul!nsThread::ProcessNextEvent + 0x569   
xul!NS_ProcessNextEvent + 0x4a   
xul!mozilla::dom::WorkerPrivate::DoRunLoop + 0x349   
xul!mozilla::dom::workerinternals::`anonymous namespace'::WorkerThreadPrimaryRunnable::Run + 0x4d4   
xul!nsThread::ProcessNextEvent + 0x569   
xul!NS_ProcessNextEvent + 0x4a   
xul!mozilla::ipc::MessagePumpForNonMainThreads::Run + 0x96   
xul!MessageLoop::AutoRunState::~AutoRunState + 0xf   
xul!MessageLoop::Run + 0x84   
xul!nsThread::ThreadFunc + 0x121   
nss3!_PR_NativeRunThread + 0x13a   
nss3!pr_root + 0xa   
ucrtbase!thread_start<unsigned int (__cdecl*)(void *),1> + 0x42   
KERNEL32!BaseThreadInitThunk + 0x14   
mozglue!mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>,void (*)(int, void *, void *)>::operator() + 0xe   
mozglue!patched_BaseThreadInitThunk + 0x6e   
ntdll!RtlUserThreadStart + 0x21   
```

After Rob's comment I installed uBlock origin and launched Tor Browser on a debugger (as I already had the needed symbols), and I detected a crash:
```
Here is the stack trace for https://boring-easley-d4cbde.netlify.app/:

```
xul!mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint + 0x2b0   
xul!mozilla::CycleCollectedJSContext::LeaveMicroTask + 0x13   
xul!mozilla::nsAutoMicroTask::~nsAutoMicroTask + 0x1d   
xul!mozilla::EventListenerManager::HandleEventSubType + 0x1ee   
xul!mozilla::EventListenerManager::HandleEventInternal + 0x4e6   
xul!mozilla::EventListenerManager::HandleEvent + 0x8d   
xul!mozilla::EventTargetChainItem::HandleEvent + 0x29c   
xul!mozilla::EventTargetChainItem::HandleEventTargetChain + 0x485   
xul!mozilla::EventDispatcher::Dispatch + 0xfe5   
xul!mozilla::EventDispatcher::DispatchDOMEvent + 0xf7   
xul!mozilla::DOMEventTargetHelper::DispatchEvent + 0x45   
xul!mozilla::dom::EventTarget::DispatchEvent + 0x34   
xul!mozilla::dom::MessageEventRunnable::DispatchDOMEvent + 0x4b2   
xul!mozilla::dom::MessageEventRunnable::WorkerRun + 0x74   
xul!mozilla::dom::WorkerRunnable::Run + 0x2b9   
xul!nsThread::ProcessNextEvent + 0x569   
xul!NS_ProcessNextEvent + 0x4a   
xul!mozilla::dom::WorkerPrivate::DoRunLoop + 0x349   
xul!mozilla::dom::workerinternals::`anonymous namespace'::WorkerThreadPrimaryRunnable::Run + 0x4d4   
xul!nsThread::ProcessNextEvent + 0x569   
xul!NS_ProcessNextEvent + 0x4a   
xul!mozilla::ipc::MessagePumpForNonMainThreads::Run + 0x96   
xul!MessageLoop::AutoRunState::~AutoRunState + 0xf   
xul!MessageLoop::Run + 0x84   
xul!nsThread::ThreadFunc + 0x121   
nss3!_PR_NativeRunThread + 0x13a   
nss3!pr_root + 0xa   
ucrtbase!thread_start<unsigned int (__cdecl*)(void *),1> + 0x42   
KERNEL32!BaseThreadInitThunk + 0x14   
mozglue!mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>,void (*)(int, void *, void *)>::operator() + 0xe   
mozglue!patched_BaseThreadInitThunk + 0x6e   
ntdll!RtlUserThreadStart + 0x21   
```

After Rob's comment I installed uBlock origin and launched Tor Browser on a debugger (as I already had the needed symbols), and I detected a crash (stack trace attached).

As regards the testcase, why is https://boring-easley-d4cbde.netlify.app/ not okay?
Is it because it has been created with react, or because it uses openpgp.js, or something else? Just to understand how I could improve it.

Tor Browser has patches on top of Firefox, but none in this part of code.
The patch for Bug 1724777  was the last one that modified `xpcom/base/CycleCollectedJSContext.cpp`. But I can build Firefox before any of our patches with and without the patch for Bug 1724777.

(ugh, sorry for the double attachment, I had an alert with error from S3 and I thought it was not added).

Back to Bug 1744719 Comment 7