> Attached a video for posting a news article for your information. All I see there is indeterminate state and no progress % that I can tell. Maybe you were just posting a very small message and it was too short to show a progress %? > BTW, setting the progress to 99% in UploadMessageFromFile() at the end results in 100% never showing. That's rather confusing. > The change in SmtpService.jsm leads to 0% being shown after a successful 100% if the message is later not IMAP copied, so for Sent folder on local folders or with no sent copy. Yes, I noticed these issues too but thought maybe they wouldn't be noticed that much unless someone recorded the screen and played it back frame by frame. The dialog should quickly transitions to output the string "Your message was sent" and set the progress to 100% in the STATE_STOP handler. However, I think something is causing the dialog to "fade away" before you can see the success message. Seem to me there should be some way to cause the final success message to show for a while (maybe 1/2 second) before it completely fades away. Maybe another CSS setting? But as it is, the 99% is not really noticeable since the dialog is fading away at that point. I've found another way to get around these issues which I'll submit next via moz-phab. The idea is to no longer try to set an artificial % of 0 or 99 but instead set the progress to indeterminate at those points. You will never see forced 0% or 99% but instead you will see just the indeterminate progress display after each phase reaches 100% or while waiting for the save/retry dialog to appear. With this method, the final 100% is sometimes not seen due to the early fade out of the progress dialog. This that is also true of how it has always worked, I think. I also went back to setting indeterminate at STATE_START and I updated the .css as per comment 103.
Bug 1745130 Comment 108 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> Attached a video for posting a news article for your information. All I see there is indeterminate state and no progress % that I can tell. Maybe you were just posting a very small message and it was too short to show a progress %? > BTW, setting the progress to 99% in UploadMessageFromFile() at the end results in 100% never showing. That's rather confusing. > The change in SmtpService.jsm leads to 0% being shown after a successful 100% if the message is later not IMAP copied, so for Sent folder on local folders or with no sent copy. Yes, I noticed these issues too but thought maybe they wouldn't be noticed that much unless someone recorded the screen and played it back frame by frame. The dialog should quickly transitions to output the string "Your message was sent" and set the progress to 100% in the STATE_STOP handler. However, I think something is causing the dialog to "fade away" before you can see the success message. Seem to me there should be some way to cause the final success message to show for a while (maybe 1/2 second) before it completely fades away. Maybe another CSS setting? But as it is, the 99% is not really noticeable since the dialog is fading away at that point. I've found another way to get around these issues which I'll submit next via moz-phab. The idea is to no longer try to set an artificial % of 0 or 99 but instead set the progress to indeterminate at those points. You will never see forced 0% or 99% but instead you will see just the indeterminate progress display after each phase reaches 100% or while waiting for the save/retry dialog to appear. With this method, the final 100% is sometimes not seen due to the early fade out of the progress dialog. This is also true of how it has always worked, I think. I also went back to setting indeterminate at STATE_START and I updated the .css as per comment 103.