Bugzilla

Patch https://phabricator.services.mozilla.com/D171035?id=688824 was approved at Fri, Mar 3, 6:34 PM. But it was quickly found that there were numerous mochitest failures, so more changes were needed to address this.

Most of the test failures were because the approved patch allows the progress window to remain open for 1 second after the test finishes. The test code then detected an unexpected window as present and flagged it as an error. To fix this, on each of the test files that produce a progress window an add_task() doing just a 3 second delay is appended at the end of the file to allow time for the progress window to close and avoid the error.

Another test failure was caused by the delay of 2 seconds in closing the compose window (needed specifically for M/S Windows) and resulted in failures in ```mail/components/extensions/test/browser/browser_ext_compose_onBeforeSend.js``` which detected a window from the previous test as still present.  The solution for this is to add a new attribute to the compose window called "destroywindow" in ```mailnews/compose/src/nsMsgCompose.cpp``` and in ```browser_ext_compose_onBeforeSend.js``` filter out and ignore old dying/closing windows from the previous test having the attribute "destroywindow".

Both solution were provided by commenter BB.

I'll submit an update moz-phab patch next.

Patch https://phabricator.services.mozilla.com/D171035?id=688824 was approved at Fri, Mar 3, 6:34 PM. But it was quickly found that there were numerous mochitest failures, so more changes were needed to address this.

Most of the test failures were because the approved patch allows the progress window to remain open for 1 second after the test finishes. The test code then detected an unexpected window as present and flagged it as an error. To fix this, on each of the test files that produce a progress window an add_task() doing just a 3 second delay is appended at the end of the file to allow time for the progress window to close and avoid the error.

Another test failure was caused by the delay of 2 seconds in closing the compose window (needed specifically for M/S Windows) and resulted in failures in ```mail/components/extensions/test/browser/browser_ext_compose_onBeforeSend.js``` or ```mail/components/extensions/test/browser/head.js``` which detected an unexpected window from the previous test as still present.  The solution for this is to add a new attribute to the compose window called "destroywindow" in ```mailnews/compose/src/nsMsgCompose.cpp``` and in ```browser_ext_compose_onBeforeSend.js``` and ``` head.js```, filter out and ignore old dying/closing compose windows from a possible previous test having the new attribute "destroywindow".

Both solution were provided by commenter BB.

I'll submit an update moz-phab patch next.
Here's my last try build with the final fix in place:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2514aee1693fa13bad319c3951dd5198b64a9ec3