Bug 1746126 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Botond Ballo [:botond] from comment #6)
> Ok, so `endZoomToMetrics.GetZoom()` being 1 explains why no zooming occurs. Next, let's see how that comes about:
> 
>  * Is `aZoomTarget.targetRect` reasonable? If the focused element is an input field, I would expect it to be the bounding box of the input field.
>  * If so, what prevents the target zoom from being something larger that would zoom in on that rect and centre it on the screen?
>    * Perhaps `mZoomConstraints.mMaxZoom` fails to reflect the `maximum-scale=2` for some reason?

```
 0:13.94 GECKO(48853) void mozilla::layers::AsyncPanZoomController::ZoomToRect(const mozilla::layers::ZoomTarget &, const uint32_t)
 0:13.94 GECKO(48853) mZoomConstraints.mMaxZoom: 10
 0:13.94 GECKO(48853) aZoomTarget.targetRect: (x=-7, y=8, w=1294, h=200)
 0:13.94 GECKO(48853) Metrics().GetZoom(): 1, endZoomToMetrics.GetZoom(): 1
```

Is `mZoomConstraints.mMaxZoom` supposed to be `10` going into ` ZoomToRect()`? Is the `2` multiplied by a factor somewhere after it's read? My viewport tag is `<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0, minimum-scale=1, maximum-scale=2, user-sca    lable=no" />`.
(In reply to Botond Ballo [:botond] from comment #6)
> Ok, so `endZoomToMetrics.GetZoom()` being 1 explains why no zooming occurs. Next, let's see how that comes about:
> 
>  * Is `aZoomTarget.targetRect` reasonable? If the focused element is an input field, I would expect it to be the bounding box of the input field.
>  * If so, what prevents the target zoom from being something larger that would zoom in on that rect and centre it on the screen?
>    * Perhaps `mZoomConstraints.mMaxZoom` fails to reflect the `maximum-scale=2` for some reason?

```
 0:13.94 GECKO(48853) void mozilla::layers::AsyncPanZoomController::ZoomToRect(const mozilla::layers::ZoomTarget &, const uint32_t)
 0:13.94 GECKO(48853) mZoomConstraints.mMaxZoom: 10
 0:13.94 GECKO(48853) aZoomTarget.targetRect: (x=-7, y=8, w=1294, h=200)
 0:13.94 GECKO(48853) Metrics().GetZoom(): 1, endZoomToMetrics.GetZoom(): 1
```

Is `mZoomConstraints.mMaxZoom` supposed to be `10` going into ` ZoomToRect()`? Is the `2` multiplied by a factor somewhere after it's read? My viewport tag is `<meta name="viewport" content="width=device-width, height=device-height, initial-scale=1.0, minimum-scale=1, maximum-scale=2, user-scalable=no" />`.

Back to Bug 1746126 Comment 7