We look at browser.search.region too much, at the same time we have DEFAULT_REGION. DEFAULT_REGION is used elsewhere in the code and it is based on Region.home. Region module deals with detecting region from browser.search.region pref or WiFi network or some other magic that is not Form Autofill concern. We should let Region.jsm deal with region detection.
Bug 1747284 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We look at browser.search.region too much, at the same time we have DEFAULT_REGION. DEFAULT_REGION is used elsewhere in the code and it is based on Region.home. Region module deals with detecting region from browser.search.region pref or WiFi network or some other magic that is not Form Autofill concern. We should let Region.jsm deal with region detection. We should rename DEFAULT_REGION to `region` or `current_region`.
We look at browser.search.region too much, at the same time we have DEFAULT_REGION. DEFAULT_REGION is used elsewhere in the code and it is based on Region.home. Region module deals with detecting region from browser.search.region pref or WiFi network or some other magic that is not Form Autofill concern. We should let Region.jsm deal with region detection. We should rename DEFAULT_REGION to `region` or `current_region`. We should add a test when browser.search.region is not set.