I believe that Bug 1726804 has broken build dependencies, possibly only for artifact builds. When I build `-j1`, the build manifest with `CrashReporter.jsm` is processed before any file generation takes place. With the `#includesubst` approach, I don't really see how the build dependencies can be determined. Perhaps something else is interfering with the `.pp`/deps mechanism that handles dependencies and that should be catching this case? In general, we should strongly avoid preprocessing JavaScript source code in this manner. I would much prefer that we use the strong dynamic facilities in JS to arrange whatever is wanted here (stitching objects together, AFAICT) at run-time rather than doing this at build-time.
Bug 1749385 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I believe that Bug 1726804 has broken build dependencies, possibly only for artifact builds. When I build `-j1`, the build manifest with `CrashManager.jsm` is processed before any file generation takes place. With the `#includesubst` approach, I don't really see how the build dependencies can be determined. Perhaps something else is interfering with the `.pp`/deps mechanism that handles dependencies and that should be catching this case? In general, we should strongly avoid preprocessing JavaScript source code in this manner. I would much prefer that we use the strong dynamic facilities in JS to arrange whatever is wanted here (stitching objects together, AFAICT) at run-time rather than doing this at build-time.