Bug 1751260 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Note that with `layout.display-list.improve-fragmentation` enabled by default, we currently can already fragment images in vertical writing-mode in printing. (Hence lower the severity to S4.)

Converting `nsImageFrame::reflow()` code to logical coordinates is probably not sufficient. Some callers in image painting related code use [`nsImageFrame::GetContinuationOffset()`](https://searchfox.org/mozilla-central/rev/7fb9750a14e99267a77328559c2fd022e360d99b/layout/generic/nsImageFrame.cpp#1180-1187) to calculate the consumed height from previous continuations. It won't work in the vertical writing-modes.  [`nsSplittableFrame::CalcAndCacheConsumedBSize()`](https://searchfox.org/mozilla-central/rev/7fb9750a14e99267a77328559c2fd022e360d99b/layout/generic/nsSplittableFrame.cpp#193) should be used instead.
Note that with `layout.display-list.improve-fragmentation` enabled by default, we currently can already fragment images in vertical writing-mode in printing. (Hence lower the severity to S4.)

Converting `nsImageFrame::Reflow()` code to logical coordinates is probably not sufficient. Some callers in image painting related code use [`nsImageFrame::GetContinuationOffset()`](https://searchfox.org/mozilla-central/rev/7fb9750a14e99267a77328559c2fd022e360d99b/layout/generic/nsImageFrame.cpp#1180-1187) to calculate the consumed height from previous continuations. It won't work in the vertical writing-modes.  [`nsSplittableFrame::CalcAndCacheConsumedBSize()`](https://searchfox.org/mozilla-central/rev/7fb9750a14e99267a77328559c2fd022e360d99b/layout/generic/nsSplittableFrame.cpp#193) should be used instead.

Back to Bug 1751260 Comment 2