Bug 1753085 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

[This](https://searchfox.org/mozilla-central/rev/38652b98c6dd3bf42403eeb8c5305902b9a6e938/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java#1344) seems to be the only location we cover it. And only if `hasSession` is `false`... which I presume is not the case if we're switching to a loaded tab? From a quick search of the code we seem to always pass a non-null session, meaning we don't cover it.

(Also, is it a bug that we always cover WHITE there instead of it depending on the theme?)

In android-components they call it [here](https://searchfox.org/mozilla-mobile/rev/c8ec80d154917909a0cfe402d7cb895af469fe67/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt#81). They set a different colour there depending on the theme, but we don't cache that. Should we be caching the colour and using it whenever geckoview itself decides to cover?
[This](https://searchfox.org/mozilla-central/rev/38652b98c6dd3bf42403eeb8c5305902b9a6e938/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java#1344) seems to be the only location we cover it. And only if `hasSession` is `false`... which I presume is not the case if we're switching to a loaded tab? From a quick search of the code we seem to always pass a non-null session, meaning we don't cover it?

(Also, is it a bug that we always cover WHITE there instead of it depending on the theme?)

In android-components they call it [here](https://searchfox.org/mozilla-mobile/rev/c8ec80d154917909a0cfe402d7cb895af469fe67/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt#81). They set a different colour there depending on the theme, but we don't cache that. Should we be caching the colour and using it whenever geckoview itself decides to cover?

Back to Bug 1753085 Comment 9