Bug 1754207 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Hey Andra. Thanks a lot for confirming the regression after 4th patch.

(In reply to Kenneth Heafield from comment #8)
> Changed iostream to fprintf in intgemm master.  
> 
> Regarding EnvironmentCPUID hiding behind a preprocessor macro, take a look at: https://github.com/kpu/intgemm/pull/98/ .  Have a look at the PR to confirm then I'll merge.  
> 
> Neither of these will change the number of static constructors metric, but as you say this is metric is more of an indicator to look at startup time.

Changes pulled as https://phabricator.services.mozilla.com/D138462:
1. Changed iostream to fprintf
2. Disabled using `getenv` by hiding `EnvironmentCPUID` behind a preprocessor macro
Revision 1 by
on 
Hey Andra. Thanks a lot for confirming the regression after 4th patch.

Changes pulled as https://phabricator.services.mozilla.com/D138462:
1. Changed iostream to fprintf
2. Disabled using `getenv` by hiding `EnvironmentCPUID` behind a preprocessor macro

Back to Bug 1754207 Comment 14