Bug 1758961 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Some parts of our refreshed Private Browsing Entry Points work are not yet finalized. Specifically: the string we're using in Shortcut descriptions, and the Icon we're using for shortcuts. These things will be landed pref'ed off for now, but must be updated before we pref on or otherwise make them user visible in any way.

The string changes are included in a few revisions that have yet to land:
https://phabricator.services.mozilla.com/D138196
https://phabricator.services.mozilla.com/D138197
https://phabricator.services.mozilla.com/D140653

The icon used is referred to by index in https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/toolkit/xre/nsNativeAppSupportWin.h#20 and https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/browser/components/BrowserContentHandler.jsm#44. If we end up just replacing the existing icon (the purple mask) this probably doesn't need to be changed. If we add a new icon, these indexes will likely need updating.
Some parts of our refreshed Private Browsing Entry Points work are not yet finalized. Specifically: the string we're using in Shortcut descriptions, and the Icon we're using for shortcuts. These things will be landed pref'ed off for now, but must be updated before we pref on or otherwise make them user visible in any way.

The string changes are included in a few revisions that have yet to land:
https://phabricator.services.mozilla.com/D138196
https://phabricator.services.mozilla.com/D138197
https://phabricator.services.mozilla.com/D140653

The icon used is referred to by index in https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/toolkit/xre/nsNativeAppSupportWin.h#20, https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/browser/components/BrowserContentHandler.jsm#44, and the yet-to-be-landed https://phabricator.services.mozilla.com/D138197. If we end up just replacing the existing icon (the purple mask) this probably doesn't need to be changed. If we add a new icon, these indexes will likely need updating.

Back to Bug 1758961 Comment 0