rtestard: how much do we care for this exact icon? Would we accept the risk of referring to Edge's icon, given that Edge could change the icon (to refer to Edge, say) without Firefox being able to intervene? My expectation is that we would not accept that risk. We could take the Beta 100 cycle to get an updated "Firefox PDF Document" icon from UX without impacting anything else here. mhowell: suppose we were to make `Computer\HKEY_CLASSES_ROOT\FirefoxPDF-...\DefaultIcon` refer to `C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe,13`, aping Edge's icon choice. Let's assume that can be `C:\Program Files\...` to benefit from the OS-aliasing or that we can determine the appropriate path at install/post-update time. Can you think of any issues not mentioned in #c0? If we did this, can you think of a slick way to detect icon changes? I was thinking that if we must we can extract the bits of some/all resolutions of the icon and verify they are well known values to determine if the icon is changed, although I'm not really eager to do that in NSIS. (Perhaps another thing to put in the WDBA binary.)
Bug 1761389 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
rtestard: how much do we care for this exact icon? Would we accept the risk of referring to Edge's icon, given that Edge could change the icon (to refer to Edge, say) without Firefox being able to intervene? My expectation is that we would not accept that risk. We could take the Beta 100 cycle to get an updated "Firefox PDF Document" icon from UX without impacting anything else here. mhowell: suppose we were to make `Computer\HKEY_CLASSES_ROOT\FirefoxPDF-...\DefaultIcon` refer to `C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe,13`, aping Edge's icon choice. Let's assume that can be `C:\Program Files\...` to benefit from the OS-aliasing or that we can determine the appropriate path at install/post-update time. Can you think of any issues not mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1761389#c0? If we did this, can you think of a slick way to detect icon changes? I was thinking that if we must we can extract the bits of some/all resolutions of the icon and verify they are well known values to determine if the icon is changed, although I'm not really eager to do that in NSIS. (Perhaps another thing to put in the WDBA binary.)