(In reply to Henry Wilkes [:henry] from comment #3) > (In reply to Thomas D. (:thomas8) from comment #0) > > - `Shift`+`End` must select all pills from focused pill to last pill > > If we want to be consistent with the XUL:tree selection behaviour, it should select from a "pivot point", which is not necessarily the last focused pill. Yes, complex selection patterns with Shift may involve extending selection from the last selected rather than last focused item. > For example, with 4 elements, "Shift+Left, Shift+Home" should select all the elements, not just 3 of them. This works with my patch. > It is a bit complicated to explain, but I'm defining the behaviour for all (multi-)selection widgets as part of bug 1752532. This area could probably inherit from it to save all the duplication. I would expect this to be non-trivial, so I think we could do an incremental improvement here. > It also seems that the current controls are the wrong way around in right-to-left. Yes, we don't cater for right-to-left yet.
Bug 1763362 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Henry Wilkes [:henry] from comment #3) > (In reply to Thomas D. (:thomas8) from comment #0) > > - `Shift`+`End` must select all pills from focused pill to last pill > > If we want to be consistent with the XUL:tree selection behaviour, it should select from a "pivot point", which is not necessarily the last focused pill. Yes, complex selection patterns with `Shift` and with or without `Ctrl` may involve extending selection from the last selected rather than last focused item. > For example, with 4 elements, "Shift+Left, Shift+Home" should select all the elements, not just 3 of them. This works with my patch. > It is a bit complicated to explain, but I'm defining the behaviour for all (multi-)selection widgets as part of bug 1752532. This area could probably inherit from it to save all the duplication. I would expect this to be non-trivial, so I think we could do an incremental improvement here. > It also seems that the current controls are the wrong way around in right-to-left. Yes, we don't cater for right-to-left yet.