Bug 1763880 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

In term of the performance, let decoding happens in GPU process would be most benefitial (no matter hw & sw) because it could help to reduce the need of copying video as much as possible (Chrome already did that) But your concern also makes sense, I don't know how gfx team think about the decoding crash would also affect the rendering. 

Jeff, I wonder what the thought from the gfx team's perspective is? Would gfx team want all video decoding happening in GPU? 

> Not sure why that line was added in the first place if the intention was never to do hardware decode there. 

The zero-copying thing was added recently, so I guess we still wanted to use RDD as a backup place for HW decoding at that time. But as what you mentioned in the comment0, this didn't happened.

> Should it be allowed as a backup without zero-copy? 

I think it won't hurt to enable HW decoding on RDD as a back up plan on Windows. 

> Make RDDParent::RecvInitVideoBridge reinitialize WMFDecoderModule, the same way RDDParent::RecvUpdateVar does.

This would result in many no-necessary initialization for `WMFDecoderModule` because RDD would need to build the video bridge for every content process which is playing video. If we do so, whenever a new content process starts playing video (we build a video bridge between them), we would initialize `WMFDecoderModule` again.
In term of the performance, let decoding happens in GPU process would be most benefitial (no matter hw & sw) because it could help to reduce the need of copying video as much as possible (Chrome already did that) But your concern also makes sense, I don't know how gfx team think about the decoding crash would also affect the rendering. 

Jeff, I wonder what the thought from the gfx team's perspective is? Would gfx team want all video decoding happening in GPU? 

> Not sure why that line was added in the first place if the intention was never to do hardware decode there. 

The zero-copying thing was added recently, so I guess we still wanted to use RDD as a backup place for HW decoding at that time. But as what you mentioned in the comment0, this didn't happened.

> Should it be allowed as a backup without zero-copy? 

I think it won't hurt to enable HW decoding on RDD as a back up plan on Windows.

Back to Bug 1763880 Comment 4