Bug 1765391 Comment 55 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

 (In reply to Steven Michaud [:smichaud] (Retired) from comment #49)
> A really simple fix occurs to me.
> 
> Stephen, you patched `nsCocoaWindow::SetMenuBar()` to defer a call to `mMenuBar->Paint()`. But there's still a call to `hiddenWindowMenuBar->Paint()` in [`-[WindowDelegate windowDidResignMain:(NSNotification*)aNotification]`](https://hg.mozilla.org/mozilla-central/file/db07c33528d623f09163e684653be46575f563e1/widget/cocoa/nsCocoaWindow.mm#l2888). Maybe you should defer that call, too.

Steven, your comment made me try to aggregate the crash reports on their proto signatures, and it turns out that there were a total of five different ways that this crash occurred. My patch should address the remaining four.
 (In reply to Steven Michaud [:smichaud] (Retired) from comment #49)
> A really simple fix occurs to me.
> 
> Stephen, you patched `nsCocoaWindow::SetMenuBar()` to defer a call to `mMenuBar->Paint()`. But there's still a call to `hiddenWindowMenuBar->Paint()` in [`-[WindowDelegate windowDidResignMain:(NSNotification*)aNotification]`](https://hg.mozilla.org/mozilla-central/file/db07c33528d623f09163e684653be46575f563e1/widget/cocoa/nsCocoaWindow.mm#l2888). Maybe you should defer that call, too.

Steven, your comment made me try to aggregate the crash reports on their proto signatures, and it turns out that there were a total of five different ways that this crash occurred. My patch addresses the remaining four.

Back to Bug 1765391 Comment 55