As per product, there could be use cases where default promo message showuld be shown after experiment promo. To cover those usecases, instead of blanket override of default , a flag in experiment message should determine if default promo should be visible or hidden. To support getting telemetry from default promo message spotlight modal, metrics flag that controls telemetry should be computed and passed dynamically. In Fx100 metric flag is set inside action.data of spotlight message https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/newtab/lib/OnboardingMessageProvider.jsm#125 In future to support collecting telemetry from default message shown in an experiment, we should compute and set this flag dynamically before passing from aboutPrivateBrowsing.js https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#123
Bug 1765907 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
As per product, in future there could be use cases where default promo message should be shown after experiment promo. To cover those usecases, instead of blanket override of default , a flag in experiment message should determine if default promo should be visible or hidden. To support getting telemetry from default promo message spotlight modal, metrics flag that controls telemetry should be computed and passed dynamically. In Fx100 metric flag is set inside action.data of spotlight message https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/newtab/lib/OnboardingMessageProvider.jsm#125 In future to support collecting telemetry from default message shown in an experiment, we should compute and set this flag dynamically before passing from aboutPrivateBrowsing.js https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#123
As per product, in future there could be use cases where default promo message should be shown after experiment promo. To cover those usecases, instead of blanket override of default , a flag in experiment message (e.g. hideDefault) should determine if default promo should be visible or hidden. To support getting telemetry from default promo message spotlight modal, metrics flag that controls telemetry should be computed and passed dynamically. In Fx100 metric flag is set inside action.data of spotlight message https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/newtab/lib/OnboardingMessageProvider.jsm#125 In future to support collecting telemetry from default message shown in an experiment, we should compute and set this flag dynamically before passing from aboutPrivateBrowsing.js https://searchfox.org/mozilla-central/rev/5204ea3d3dac5832075fb61d9689dd7879ed91b2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#123