Bug 1769579 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I just looked in the analysis environment and I do indeed see the new "unenrollment" table.

However, I now also see an "onboarding" table that I don't think was there before. I looked through the commit history and it looks like an "onboarding" ping was introduced in [this commit](https://github.com/mozilla-rally/rally/commit/69559324f775b79c9a39c6a95fdb3657c184ed0e) but subsequently removed in [this commit](https://github.com/mozilla-rally/rally/commit/f633df7676b6ef64e496fea1b3687eff22680d49) and never re-added.

I'm _guessing_ this is happening because that second commit where the "onboarding" ping was removed is also now being [ignored by probe-scraper](https://github.com/mozilla/probe-scraper/blob/1a127e15de1bde4b2bebdbc3993b5422fda8ac63/probe_scraper/scrapers/git_scraper.py#L66) as per :relud's necessary patch. So the schema generation process never sees that ping get removed.

For the time being, I don't think it's a blocking issue for us to have an extraneous table (correct me if I'm wrong). But it would be good to get rid of it so as not to cause confusion. Let me know how we can proceed with that.
I just looked in the analysis environment and I do indeed see the new "unenrollment" table.

However, I now also see an "onboarding" table that I don't think was there before. I looked through the commit history and it looks like an "onboarding" ping was introduced in [this commit](https://github.com/mozilla-rally/rally/commit/69559324f775b79c9a39c6a95fdb3657c184ed0e) but subsequently removed in [this commit](https://github.com/mozilla-rally/rally/commit/f633df7676b6ef64e496fea1b3687eff22680d49) and never re-added.

I'm _guessing_ this is happening because that second commit where the "onboarding" ping was removed is also now being [ignored by probe-scraper](https://github.com/mozilla/probe-scraper/blob/1a127e15de1bde4b2bebdbc3993b5422fda8ac63/probe_scraper/scrapers/git_scraper.py#L66) as per :relud's necessary patch. So the schema generation process never sees that ping get removed.

For the time being, I don't think it's a blocking issue for us to have an extraneous table (correct me if I'm wrong). But it would be good to get rid of it so as not to cause confusion. Let me know how we can proceed with that, including if I should file a new bug.

Back to Bug 1769579 Comment 18