Bug 1769786 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Found the reason for it.
That test case is testing that the error page is shown correct. 
For that reason the test case requests something from a server that is not supporting https --> the error page gets displays since https-only can't upgrade it. The test is successful because the shown error page is correct.
But also since the browser never reached to the requested site everything in `dom/security/test/https-only/file_user_suggestion_box.sjs` won't get executed ever and is actually also not tested.

So I guess we should consider to delete  `dom/security/test/https-only/file_user_suggestion_box.sjs` and delete this line: https://searchfox.org/mozilla-central/source/dom/security/test/https-only/test_user_suggestion_box.html#26

As far as I understand the test it should test that a error page is different for "www.example.com" and "http://example.com" requests if example.com is not supporting https.
Is a test case for this pref: https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#3411-3413,3415.
Found the reason for it.
That test case is testing that the error page is shown correct. 
For that reason the test case requests something from a server that is not supporting https --> the error page gets displays since https-only can't upgrade it. The test is successful because the shown error page is correct.
But also since the browser never reached to the requested site everything in `dom/security/test/https-only/file_user_suggestion_box.sjs` won't get executed ever and is actually also not tested and arbitary.

So I guess we should consider to delete  `dom/security/test/https-only/file_user_suggestion_box.sjs` and delete this line: https://searchfox.org/mozilla-central/source/dom/security/test/https-only/test_user_suggestion_box.html#26

As far as I understand the test it should test that a error page is different for "www.example.com" and "http://example.com" requests if example.com is not supporting https.
Is a test case for this pref: https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#3411-3413,3415.
Found the reason for it.
That test case is testing that the error page is shown correct. 
For that reason the test case requests something from a server that is not supporting https --> the error page gets displays since https-only can't upgrade it. The test is successful because the shown error page is correct.
But also since the browser never reached to the requested site everything in `dom/security/test/https-only/file_user_suggestion_box.sjs` won't get executed ever and is actually also not tested and arbitary.

So I guess we should consider to delete  `dom/security/test/https-only/file_user_suggestion_box.sjs` and delete this line: https://searchfox.org/mozilla-central/source/dom/security/test/https-only/test_user_suggestion_box.html#26

Then we should be fine since there are other test which test the correct behavior of the https-only error page.
Found the reason for it.
That test case is testing that the error page is shown correct. 
For that reason the test case requests something from a server that is not supporting https --> the error page gets displays since https-only can't upgrade it. The test is successful because the shown error page is correct.
But also since the browser never reached to the requested site everything in `dom/security/test/https-only/file_user_suggestion_box.sjs` won't get executed ever and is actually also not tested and arbitary.

So I guess we should consider to delete  `dom/security/test/https-only/file_user_suggestion_box.sjs` and delete this line: https://searchfox.org/mozilla-central/source/dom/security/test/https-only/test_user_suggestion_box.html#26

Then we should be fine since there are other tests which test the correct behavior of the https-only error page.

Back to Bug 1769786 Comment 3