Bug 1773282 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Backed out for causing bp-hybrid bustages on FFmpegLibWrapper.

[Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cplain%2Cbuild-linux64-hybrid%2Fplain%2Cbp-hybrid&tochange=0ec63154907153872e6e4c34e3d7c03321f01c93&fromchange=ec0bd8f37b9abfd2d0ac7c22a7ef5cbfb7323980&selectedTaskRun=Xo2Yi2u-Rw-4AvneNGnbjw.0)

[Failure log](https://treeherder.mozilla.org/logviewer?job_id=382509817&repo=autoland&lineNumber=28158)

[Backout link](https://hg.mozilla.org/integration/autoland/rev/074f32bcc58f2ab8572581ffc8f7f539c74e74fb)
```
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o FFmpegLibWrapper.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/platforms -I/builds/worker/workspace/obj-build/dom/media/platforms -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/FFmpegLibWrapper.o.pp   /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp:287:13: error: no member named 'gfxVars' in namespace 'mozilla::gfx'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -    if (!gfx::gfxVars::CanUseHardwareVideoDecoding() || !XRE_IsRDDProcess()) {
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -         ~~~~~^
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  1 error generated.
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:667: FFmpegLibWrapper.o] Error 1
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-06-25T09:08:28.550Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  dom/media/webaudio/AudioNodeExternalInputTrack.o
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.594Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/gmp'
```
Revision 1 by
on 
Backed out for causing bp-hybrid bustages on FFmpegLibWrapper.

**Later, this xpcshell started to fail on test_gfxBlacklist_Version.js:** https://treeherder.mozilla.org/logviewer?job_id=382509376&repo=autoland&lineNumber=4268

[Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cplain%2Cbuild-linux64-hybrid%2Fplain%2Cbp-hybrid&tochange=0ec63154907153872e6e4c34e3d7c03321f01c93&fromchange=ec0bd8f37b9abfd2d0ac7c22a7ef5cbfb7323980&selectedTaskRun=Xo2Yi2u-Rw-4AvneNGnbjw.0)

[Failure log](https://treeherder.mozilla.org/logviewer?job_id=382509817&repo=autoland&lineNumber=28158)

[Backout link](https://hg.mozilla.org/integration/autoland/rev/074f32bcc58f2ab8572581ffc8f7f539c74e74fb)
```
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o FFmpegLibWrapper.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/platforms -I/builds/worker/workspace/obj-build/dom/media/platforms -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/FFmpegLibWrapper.o.pp   /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp:287:13: error: no member named 'gfxVars' in namespace 'mozilla::gfx'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -    if (!gfx::gfxVars::CanUseHardwareVideoDecoding() || !XRE_IsRDDProcess()) {
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -         ~~~~~^
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  1 error generated.
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:667: FFmpegLibWrapper.o] Error 1
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-06-25T09:08:28.550Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  dom/media/webaudio/AudioNodeExternalInputTrack.o
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.594Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/gmp'
```
Revision 2 by
on 
Backed out for causing bp-hybrid bustages on FFmpegLibWrapper.

**Later, this xpcshell job started to fail on test_gfxBlacklist_Version.js:** https://treeherder.mozilla.org/logviewer?job_id=382509376&repo=autoland&lineNumber=4268

[Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cplain%2Cbuild-linux64-hybrid%2Fplain%2Cbp-hybrid&tochange=0ec63154907153872e6e4c34e3d7c03321f01c93&fromchange=ec0bd8f37b9abfd2d0ac7c22a7ef5cbfb7323980&selectedTaskRun=Xo2Yi2u-Rw-4AvneNGnbjw.0)

[Failure log](https://treeherder.mozilla.org/logviewer?job_id=382509817&repo=autoland&lineNumber=28158)

[Backout link](https://hg.mozilla.org/integration/autoland/rev/074f32bcc58f2ab8572581ffc8f7f539c74e74fb)
```
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o FFmpegLibWrapper.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/platforms -I/builds/worker/workspace/obj-build/dom/media/platforms -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/FFmpegLibWrapper.o.pp   /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  /builds/worker/checkouts/gecko/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp:287:13: error: no member named 'gfxVars' in namespace 'mozilla::gfx'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -    if (!gfx::gfxVars::CanUseHardwareVideoDecoding() || !XRE_IsRDDProcess()) {
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -         ~~~~~^
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  1 error generated.
[task 2022-06-25T09:08:28.543Z] 09:08:28    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:667: FFmpegLibWrapper.o] Error 1
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/platforms'
[task 2022-06-25T09:08:28.543Z] 09:08:28     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-06-25T09:08:28.550Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  dom/media/webaudio/AudioNodeExternalInputTrack.o
[task 2022-06-25T09:08:28.551Z] 09:08:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/webaudio'
[task 2022-06-25T09:08:28.594Z] 09:08:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/gmp'
```

Back to Bug 1773282 Comment 8