Bug 1774201 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Jamie Nicol [:jnicol] from comment #0)
> 
> If we changed the early-exit condition to `if (mLayersConnected.isNothing())` that would fix this. (As the value is `Some(false)`). Sotaro, do you remember if doing that would still fix bug 1728062?

Hmm, it does not fix bug 1728062:( The problem is that "mLayersConnected == Some(true)" has the following 2 meanings.
- [1] parent side requested to connect layers.
- [2] parent side requested to connect layers, but the connect was failed.

We need to distinguish between [1] and [2].
(In reply to Jamie Nicol [:jnicol] from comment #0)
> 
> If we changed the early-exit condition to `if (mLayersConnected.isNothing())` that would fix this. (As the value is `Some(false)`). Sotaro, do you remember if doing that would still fix bug 1728062?

Hmm, it does not fix bug 1728062:( The problem is that "mLayersConnected == Some(false)" has the following 2 meanings.
- [1] parent side does not request to connect layers.
- [2] parent side requested to connect layers, but the connect was failed.

We need to distinguish between [1] and [2].
(In reply to Jamie Nicol [:jnicol] from comment #0)
> 
> If we changed the early-exit condition to `if (mLayersConnected.isNothing())` that would fix this. (As the value is `Some(false)`). Sotaro, do you remember if doing that would still fix bug 1728062?

Hmm, it does not fix bug 1728062:( The problem is that "mLayersConnected == Some(false)" has the following 2 meanings.
- [1] parent side does not request to connect layers.
- [2] parent side requested to connect layers, but the connect was failed.

We need to distinguish between [1] and [2]. And also need to take care crash before InitRendering.

Back to Bug 1774201 Comment 4