Bug 1774489 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The following browser-chrome mochitest test will leak 6 `StringAdopt` objects:

```js
/* Any copyright is dedicated to the Public Domain.
 * http://creativecommons.org/publicdomain/zero/1.0/ */

"use strict";

add_task(async () => {
  Assert.equal(
    undefined,
    Glean.testOnlyIpc.eventWithExtra.testGetValue(),
    "Nothing to begin with"
  );  
  Glean.testOnlyIpc.eventWithExtra.record({
    extra1: "Some extra string",
    extra2: 42, 
    extra3_longer_name: false,
  }); 
  Assert.equal(
    1,  
    Glean.testOnlyIpc.eventWithExtra.testGetValue().length,
    "One event? One event."
  );  

  // AND NOW, FOR THE TRUE TEST:
  // Will this leak memory all over the place?
});
```

This isn't great and should be looked into.
Revision 1 by
on 
The following browser-chrome mochitest test will leak 6 `StringAdopt` objects (if you comment out one of the extra key/value pairs, it will leak 4):

```js
/* Any copyright is dedicated to the Public Domain.
 * http://creativecommons.org/publicdomain/zero/1.0/ */

"use strict";

add_task(async () => {
  Assert.equal(
    undefined,
    Glean.testOnlyIpc.eventWithExtra.testGetValue(),
    "Nothing to begin with"
  );  
  Glean.testOnlyIpc.eventWithExtra.record({
    extra1: "Some extra string",
    extra2: 42, 
    extra3_longer_name: false,
  }); 
  Assert.equal(
    1,  
    Glean.testOnlyIpc.eventWithExtra.testGetValue().length,
    "One event? One event."
  );  

  // AND NOW, FOR THE TRUE TEST:
  // Will this leak memory all over the place?
});
```

This isn't great and should be looked into.

Back to Bug 1774489 Comment 0