Ah, it turns out that we need to define HTML attribute width and height on the iframes that our GPT shims. That fixes the site, but leaves behind empty "Advertisement" sections. Those can be avoided by claiming that the slots are indeed empty, but to fix bug 1762851 we changed it to pretend they aren't as Carousell.sg was badly broken without that fix. However, after a little more digging around, I've found that the problem on Carousell isn't that it needs us to claim the slot isn't empty; it's just erroneously trying to use the same HTML element for multiple slots, which GPT normally throws an exception for, but our shim does not. This lead to Carousell's site getting into an endless loop. That's an easy fix, and doesn't seem to break other sites, so I'll fix all of these here.
Bug 1775099 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Ah, it turns out that we need to define HTML attribute width and height on the iframes that our GPT shim adds. That fixes the site, but leaves behind empty "Advertisement" sections. Those can be avoided by claiming that the slots are indeed empty, but to fix bug 1762851 we changed it to pretend they aren't as Carousell.sg was badly broken without that fix. However, after a little more digging around, I've found that the problem on Carousell isn't that it needs us to claim the slot isn't empty; it's just erroneously trying to use the same HTML element for multiple slots, which GPT normally throws an exception for, but our shim does not. This lead to Carousell's site getting into an endless loop. That's an easy fix, and doesn't seem to break other sites, so I'll fix all of these here.
Ah, it turns out that we need to define HTML attribute width and height on the iframes that our GPT shim adds. That fixes the site, but leaves behind empty "Advertisement" sections. Those can be avoided by claiming that the slots are indeed empty, but to fix bug 1762851 we changed it to pretend they aren't as Carousell.sg was badly broken without that fix. However, after a little more digging around, I've found that the problem on Carousell isn't that it needs us to claim the slot isn't empty; it's just erroneously trying to use the same HTML element for multiple slots, which GPT normally throws an exception for, but our shim does not. This leads to Carousell's site getting into an endless loop. That's an easy fix, and doesn't seem to break other sites, so I'll fix all of these here.