Bugzilla

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
> Created attachment 9311770 [details]
> setting-animation-composition-in-keyframe
> 
> (In reply to Boris Chiou [:boris] from comment #2)
> > Thanks for this example. Perhaps we don't need to update the animation panel for this property. However, I noticed one thing:
> > 
> > when I add `animation-composition:add;` into the first keyframe (e.g. "20%, 40%" keyframe) via DevTools, the animation doesn't update immediately. However, adding `animation-timing-function: step-start;` into the first keyframe makes the animation update immediately. Basically, both `animation-timing-function` and `animation-composition` have special meaning in keyframes, so perhaps we need to update animation when changing `animation-composition` in the keyframes. Do I miss something to update?
> 
> Do you mean adding the property in the "keyframes" section, like in the screenshot?
Yes

> I don't think there's anything special we need to do, the property should be set on the rule.
> I can see that editing the property in the Style Editor panel, it seems to be picked, but only after adding other properties, but I can reproduce this without involving DevTools at all:
> 
> 1. Go to https://ffx-animation-composition-update-keyframe.glitch.me/
> 1. Click on the `Set animation-composition:add on first keyframe` button -> nothing happens
> 1. Click on the `Set outline on first keyframe` -> the animation gets updated, and `animation-composition:add` seems to be picked up

Seems I misunderstand this feature. We have to wait for the style tree refresh to apply the new animation-composition. So Perhaps we don't need this bug now because nothing needs to be added.

Thanks for handling this and providing the example

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
> > when I add `animation-composition:add;` into the first keyframe (e.g. "20%, 40%" keyframe) via DevTools, the animation doesn't update immediately. However, adding `animation-timing-function: step-start;` into the first keyframe makes the animation update immediately. Basically, both `animation-timing-function` and `animation-composition` have special meaning in keyframes, so perhaps we need to update animation when changing `animation-composition` in the keyframes. Do I miss something to update?
> 
> Do you mean adding the property in the "keyframes" section, like in the screenshot?
Yes

> I don't think there's anything special we need to do, the property should be set on the rule.
> I can see that editing the property in the Style Editor panel, it seems to be picked, but only after adding other properties, but I can reproduce this without involving DevTools at all:
> 
> 1. Go to https://ffx-animation-composition-update-keyframe.glitch.me/
> 1. Click on the `Set animation-composition:add on first keyframe` button -> nothing happens
> 1. Click on the `Set outline on first keyframe` -> the animation gets updated, and `animation-composition:add` seems to be picked up

Seems I misunderstand this feature. We have to wait for the style tree refresh to apply the new animation-composition. So Perhaps we don't need this bug now because nothing needs to be added.

Thanks for handling this and providing the example