Bugzilla

(In reply to James Teh [:Jamie] from comment #3)
> (In reply to Ania from comment #2)
> > Asa, James, I wanted to confirm if we should announce the keyboard shortcuts, not just the labels, on focused states too?
> 
> Note that I'm blind, so I can't see the design spec.
> 
> I assume the keyboard shortcuts aren't displayed except when the control is hovered or focused?
> Are they displayed as a tooltip or does the control expand somehow?
> 
> Rather than including the keyboard shortcut in the aria-label, I think it's probably best that we put the keyboard shortcut in aria-keyshortcuts instead. This allows the keyboard shortcuts to be semantically separated from the label. The answers to the above questions might impact my thinking here, though.
> 
> The problem is that right now, Gecko doesn't support aria-keyshortcuts very well; see bug 1467382. That's something the a11y team will need to fix. I don't think this work needs to be blocked on that, but users won't be able to benefit from the PiP fix until the a11y engine bug is fixed.

Hi James,

Ania is on PTO right now, but I'm helping mentor this ticket that a contributor from the Outreachy program is working on. To answer your questions: based on how the Picture in Picture window works right now, the keyboard shortcut for a button is displayed through a tooltip when hovered on, but not when focused. Currently, we are using the [title](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title) attribute to display the shortcuts on hover.

Despite not being well supported by Gecko yet, are you still suggesting that we use aria-keyshortcuts? Or do you recommend that we leave the aria-labels as they are until a fix is provided? I just want to make sure I'm understanding your comment correctly.

(In reply to James Teh [:Jamie] from comment #3)
> (In reply to Ania from comment #2)
> > Asa, James, I wanted to confirm if we should announce the keyboard shortcuts, not just the labels, on focused states too?
> 
> Note that I'm blind, so I can't see the design spec.
> 
> I assume the keyboard shortcuts aren't displayed except when the control is hovered or focused?
> Are they displayed as a tooltip or does the control expand somehow?
> 
> Rather than including the keyboard shortcut in the aria-label, I think it's probably best that we put the keyboard shortcut in aria-keyshortcuts instead. This allows the keyboard shortcuts to be semantically separated from the label. The answers to the above questions might impact my thinking here, though.
> 
> The problem is that right now, Gecko doesn't support aria-keyshortcuts very well; see bug 1467382. That's something the a11y team will need to fix. I don't think this work needs to be blocked on that, but users won't be able to benefit from the PiP fix until the a11y engine bug is fixed.

Hi James,

Ania is on PTO right now, but I'm helping mentor this ticket that a contributor from the Outreachy program is working on. To answer your questions: based on how the Picture in Picture window works right now, the keyboard shortcut for a button is displayed through a tooltip when hovered on, but not when focused. Currently, we are using the [title](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title) attribute to display the shortcuts on hover (hence why it does not appear on focus).

Despite not being well supported by Gecko yet, are you still suggesting that we use aria-keyshortcuts? Or do you recommend that we leave the aria-labels as they are until a fix is provided? I just want to make sure I'm understanding your comment correctly.