Bug 1782481 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

+++ This bug was initially created as a clone of Bug #1777156 +++

We're no longer using "SecondEmail" now that we support more.
So instances of "SecondEmail" in the code have a high risk of causing weird bugs.
We should eliminate those instances before wasting resources on such bugs.
I suggest to fix this in **satellite bugs which block this meta bug**.

I've updated Henry's query to exclude SeaMonkey.
https://searchfox.org/comm-central/search?q=SecondEmail&path=%5Email&case=false&regexp=false


(In reply to Henry Wilkes (they/them) [:henry] from Bug 1777156  comment #4)
> And I think this method is still using "SecondEmail", which is not set anymore https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mailnews/addrbook/modules/AddrBookDirectory.jsm#447-451
> 
> It seems "SecondEmail" is still used in a number of places https://searchfox.org/comm-central/search?q=SecondEmail&path=&case=false&regexp=false
> 
> Geoff or Nicolai will know better what to do to replace these.
+++ This bug was initially created as a clone of Bug #1777156 +++

~We're no longer using "SecondEmail" now that we support more.~

[Edit: The premise of this bug isn't quite right, see comment 1]

So instances of "SecondEmail" in the code have a high risk of causing weird bugs.
We should eliminate those instances before wasting resources on such bugs.
I suggest to fix this in **satellite bugs which block this meta bug**.

I've updated Henry's query to exclude SeaMonkey.
https://searchfox.org/comm-central/search?q=SecondEmail&path=%5Email&case=false&regexp=false


(In reply to Henry Wilkes (they/them) [:henry] from Bug 1777156  comment #4)
> And I think this method is still using "SecondEmail", which is not set anymore https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mailnews/addrbook/modules/AddrBookDirectory.jsm#447-451
> 
> It seems "SecondEmail" is still used in a number of places https://searchfox.org/comm-central/search?q=SecondEmail&path=&case=false&regexp=false
> 
> Geoff or Nicolai will know better what to do to replace these.
+++ This bug was initially created as a clone of Bug #1777156 +++

~We're no longer using "SecondEmail" now that we support more.~

[Edit: The premise of this bug isn't quite right, see comment 1]

So instances of "SecondEmail" in the code have a high risk of causing weird bugs.
We should double-check if we need to eliminate/fix some old instances before wasting resources on such bugs.
I suggest to fix this in **satellite bugs which block this meta bug**.

I've updated Henry's query to exclude SeaMonkey.
https://searchfox.org/comm-central/search?q=SecondEmail&path=%5Email&case=false&regexp=false


(In reply to Henry Wilkes (they/them) [:henry] from Bug 1777156  comment #4)
> And I think this method is still using "SecondEmail", which is not set anymore https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mailnews/addrbook/modules/AddrBookDirectory.jsm#447-451
> 
> It seems "SecondEmail" is still used in a number of places https://searchfox.org/comm-central/search?q=SecondEmail&path=&case=false&regexp=false
> 
> Geoff or Nicolai will know better what to do to replace these.

Back to Bug 1782481 Comment 0