Bug 1783207 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hey Meridel, that makes perfect sense. I just miscommunicated. Basically there are two other menuitems/toolbarbuttons that also open the Edit Bookmark Panel, like the `Bookmark Page` item does. Those ones do not have ellipses, so they would appear inconsistent if we added an ellipsis to the `Bookmark Page` item. But I think my vote would be for them to all get ellipses. If that sounds right, then I can add ellipses to the other equivalent items too.

I think the confusion is just that one of them said no change in your recommendations, the `Bookmark Current Tab` item in the OS Menu bar. (There's also a toolbarbutton version of it in the app menu panel) When the current tab is bookmarked, they both change to `Edit this bookmark` (in either title case or sentence case), also without an ellipsis, but they continue to open the Edit Bookmark Panel. So I figure we'd wanna change `Edit this bookmark` to `Edit this bookmark...` as well?
Hey Meridel, that makes perfect sense. I just miscommunicated. Basically there are two other menuitems/toolbarbuttons that also open the Edit Bookmark Panel, like the `Bookmark Page` item does. Those ones do not have ellipses, so they would appear inconsistent if we added an ellipsis to the `Bookmark Page` item. But I think my vote would be for them to all get ellipses. If that sounds right, then I can add ellipses to the other equivalent items too.

I think the confusion is just that one of them said no change in your recommendations, the `Bookmark Current Tab` item in the OS Menu bar. (There's also a toolbarbutton version of it in the Bookmarks subview of the app menu panel) When the current tab is bookmarked, they both change to `Edit this bookmark` (in either title case or sentence case), also without an ellipsis, but they continue to open the Edit Bookmark Panel. So I figure we'd wanna change `Edit this bookmark` to `Edit this bookmark...` as well?

Back to Bug 1783207 Comment 4