Bug 1784446 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Maybe this is a "feature" but I can't test how this behaves on Windows as I have no Windows machines to test.

On Linux, as far as I know, the only way supported for "managed properties" is to use a manifest file. And if this file just does not exist, then the returned promise is rejected:

"Managed storage manifest not found"
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-storage.js#296

Now I'm wondering what happens on Windows where more than this one way of setting the managed preferences is supported?
If just using the Add-on on Windows without doing any managed preferences setup does not cause the promise to be rejected, then a non-existing manifest file should also not cause the reject on Linux.

Current behaviour:
Using "storage.managed.get()" with no manifest file causes the returned promise to be rejected.

Expected behaviour:
No manifest file means no managed preferences. So I would expect the promise to be resolved with an empty object.

Could be an issue on Mac OS, too: https://github.com/sourcegraph/sourcegraph/issues/16339
Maybe this is a "feature" but I can't test how this behaves on Windows as I have no Windows machines to test.

On Linux, as far as I know, the only way supported for "managed properties" is to use a manifest file. And if this file just does not exist, then the returned promise is rejected:

"Managed storage manifest not found"
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-storage.js#296

Now I'm wondering what happens on Windows where more than this one way of setting the managed preferences is supported?
If just using the Add-on on Windows without doing any managed preferences setup does not cause the promise to be rejected, then a non-existing manifest file should also not cause the reject on Linux.

Current behaviour:
Using "storage.managed.get()" with no manifest file causes the returned promise to be rejected.

Expected behaviour:
No manifest file means no managed preferences. So I would expect the promise to be resolved with an empty object.

Could be an issue on Mac OS, too: https://github.com/sourcegraph/sourcegraph/issues/16339

Edit: The main reason why this is critical is that it seems like this bug does not exist on Windows. Probably because on Windows the "manifest file" is not the only target for getting managed properties. So if an Add-on, that uses the "storage.managed" feature, is only tested on Windows, then this Add-on will not work on anything besides Windows as the developer does not see the need for a "try/catch" block here.

Back to Bug 1784446 Comment 0