Bug 1785914 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I haven't followed all the details yet, but comment 3 seems indicating that we _shouldn't_ let `aspect-ratio` affects content-size suggestion. If so, we  shouldn't land my patches in bug 1735589. (Note [Bug 1735589 Part 1](https://phabricator.services.mozilla.com/D131260) allows aspect-ratio to affect content size suggestion when the main axis is the block-axis).

To fix this bug, we can add `sizeOverrides.mAspectRatio.emplace(AspectRatio());` after [this line](https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/layout/generic/nsFlexContainerFrame.cpp#1713) when computing content-size suggestion if the main-axis is the inline-axis.
I haven't followed all the details yet, but comment 3 seems indicating that we _shouldn't_ let `aspect-ratio` affects content-size suggestion. If so, we  shouldn't land my patches in bug 1735589. (Note [Bug 1735589 Part 1](https://phabricator.services.mozilla.com/D131260) allows aspect-ratio to affect content size suggestion when the main-axis is the block-axis).

To fix this bug, we can add `sizeOverrides.mAspectRatio.emplace(AspectRatio());` after [this line](https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/layout/generic/nsFlexContainerFrame.cpp#1713) when computing content-size suggestion if the main-axis is the inline-axis.

Back to Bug 1785914 Comment 3