Bug 1786171 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
> Makoto, you fixed bug related to screen orientation and exiting full screen (bug 1757431) in Fenix 101. Could this GeckoViewExample bug be a regression from your fix for bug 1757431?

No, we don't turn on screen orientation API on GV as default. Although YouTube uses screen orientation API if available, we don't do anything since screen orientation API throws exception. My understand is that `orientation.lock` in YouTube content script won't work due to bug 1744288 even if pref is turned on.
Revision 1 by
on 
> Makoto, you fixed bug related to screen orientation and exiting full screen (bug 1757431) in Fenix 101. Could this GeckoViewExample bug be a regression from your fix for bug 1757431?

No, we don't turn on screen orientation API on GV as default. Although YouTube uses screen orientation API if available, we don't do anything since screen orientation API throws exception. Also, my understand is that `orientation.lock` in YouTube content script won't work due to bug 1744288 even if pref is turned on.
Revision 2 by
on 
> Makoto, you fixed bug related to screen orientation and exiting full screen (bug 1757431) in Fenix 101. Could this GeckoViewExample bug be a regression from your fix for bug 1757431?

No, we don't turn on screen orientation API on GV as default. Although YouTube uses screen orientation API if available, we don't do anything since screen orientation API throws exception.

I guess that this depends on other delegate (MediaSession and ContentDelegate) implementation. We need a complete sample to reproduce this.

Back to Bug 1786171 Comment 6