Bugzilla

I think Tom is probably right in terms of that working... or at least I hope he is.

I'm actually a bit confused about how this is all supposed to work. Ehsan created this helper in https://phabricator.services.mozilla.com/D20239 and friends, and Nika reviewed. But at the time, the internals of `GetInstance` called the `do_getService` helper, which if the service doesn't exist will call `CreateInstance` which in turn will call `Init()` (see [generated code](https://searchfox.org/mozilla-central/source/__GENERATED__/__android-aarch64__/xpcom/components/StaticComponents.cpp#10598-10601)). Then later changes made the internals of `GetInstance` use `  tldService = mozilla::components::EffectiveTLD::Service()` instead. I would expect that to be idempotent but apparently it's not? Basically I don't understand. Nika reviewed Ehsan's patch and presumably understands all the goop and where the goop is currently not working...

I think Tom is probably right in terms of that working... or at least I hope he is.

I'm actually a bit confused about how this is all supposed to work. Ehsan created this helper in https://phabricator.services.mozilla.com/D20239 and friends, and Nika reviewed. But at the time, the internals of `GetInstance` called the `do_getService` helper, which if the service doesn't exist will call `CreateInstance` which in turn will call `Init()` (see [generated code](https://searchfox.org/mozilla-central/source/__GENERATED__/__android-aarch64__/xpcom/components/StaticComponents.cpp#10598-10601)). Then later changes made the internals of `GetInstance` use `  tldService = mozilla::components::EffectiveTLD::Service()` instead. I would expect that to be doing the same as the `do_getService` call but apparently it's not? Basically I don't understand. Nika reviewed Ehsan's patch and presumably understands all the goop and where the goop is currently not working...