(In reply to Shane Hughes [:aminomancer] from comment #14) > Created attachment 9298004 [details] > border around main section, progress bar with no border-radius > > In bug 1793401 we added a HCM-compatible background color to the illustration section, so this changes how the progress bar fits with the section to its left. But I think this would be a good opportunity to add a border to the main section, since normally (in non-HCM) the main section would be more defined with respect to the page background. I guess it's really just a coincidence that the page background and the main section background resolve to the same color in HCM. But we can work around that with a border. I think that also allows us to make the progress bar in HCM diverge less in appearance from the progress bar in non-HCM. Thank you! The widget looks great on HCM (WinOS screenshot is attached) Just in case, for the borders of a content sections on HCM `CanvasText` is usually used. Alternatively, WinOS uses thick `SelectedItem` border to highlight windows that are currently focused.
Bug 1790660 Comment 18 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Shane Hughes [:aminomancer] from comment #14) > Created attachment 9298004 [details] > border around main section, progress bar with no border-radius > > In bug 1793401 we added a HCM-compatible background color to the illustration section, so this changes how the progress bar fits with the section to its left. But I think this would be a good opportunity to add a border to the main section, since normally (in non-HCM) the main section would be more defined with respect to the page background. I guess it's really just a coincidence that the page background and the main section background resolve to the same color in HCM. But we can work around that with a border. I think that also allows us to make the progress bar in HCM diverge less in appearance from the progress bar in non-HCM. Thank you! The widget looks great on HCM (WinOS screenshot is attached) Just in case, for the borders of a content sections on HCM `CanvasText` is usually used. Alternatively, WinOS uses thick `SelectedItem` border to highlight windows that are currently focused. UPD after reviewing the patch: Exactly as you did :) It looks great!