Bug 1791098 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Timothy Nikkel (:tnikkel) from comment #4)
> So far I haven't been able to reproduce the favicon blink.

I'm not seeing it right now either (though I think it was always a bit hard to see or trigger; it was lucky that I caught it in the screencast I think).

(In reply to :Gijs (he/him) from comment #5)
> Was this a debug build, by any chance?

It was a regular Nightly (not a debug build).

> I've changed bug 1791089 to capture avoiding the update entirely if the contents aren't changing, which will help with the general problem.

Thanks!

> We didn't bother initially because for 3 cards it's hardly worth the code that the performance optimization would take... Anyway, I think in this bug I'd like to cover avoiding the reflow of the last active badge,

Sounds good.
(In reply to Timothy Nikkel (:tnikkel) from comment #4)
> So far I haven't been able to reproduce the favicon blink.

I'm not seeing it right now either (though I think it was always a bit hard to see or trigger; it was lucky that I caught it in the screencast I think).

(In reply to :Gijs (he/him) from comment #5)
> Was this a debug build, by any chance?

It was a regular Nightly (not a debug build).

> I've changed bug 1791089 to capture avoiding the update entirely if the contents aren't changing, which will help with the general problem.

Thanks!

> We didn't bother initially because for 3 cards it's hardly worth the code that the performance optimization would take... Anyway, I think in this bug I'd like to cover avoiding the reflow of the last active badge,

Sounds good.  That part I can definitely still repro/see with STR in comment 0.

Back to Bug 1791098 Comment 7