A Google search for "UBSan Regex" turns up this blog post from 2020: https://devblogs.microsoft.com/cppblog/c20-features-and-fixes-in-vs-2019-16-1-through-16-6/ ...which mentions the following issue as being fixed in Visual Studio 2019 16.4: > Explicitly specified the underlying types of some enumeration types in <regex> that use bitwise operations to avoid storing an unrepresentable value (which is formally undefined behavior, as noted by Clang’s UBSAN). Presumably we're building with an older MSVC here (I see the paths in comment 0 have `14.16.27023`; not sure about version numbering here but maybe this is "version 14" which is less than "version 16". Tyson, not sure if comment 0 was your local machine vs. some infrastructure in the cloud; either way, I wonder if you know what MSVC version we're using? The best fix here is probably to install updates to pick up the fix noted in the blog post above, if we can do that. I think we're safe to call this INVALID as a Firefox bug, though feel free to reopen if there's code changes we do in fact need to make here.
Bug 1792086 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
A Google search for "UBSan Regex" turns up this blog post from 2020: https://devblogs.microsoft.com/cppblog/c20-features-and-fixes-in-vs-2019-16-1-through-16-6/ ...which mentions the following issue as being fixed in Visual Studio 2019 16.4: > Explicitly specified the underlying types of some enumeration types in <regex> that use bitwise operations to avoid storing an unrepresentable value (which is formally undefined behavior, as noted by Clang’s UBSAN). That sounds like an exact match for what I described in comment 2. So: hooray, it's fixed upstream, as of 2020! Presumably we're building with an older MSVC here (I see the paths in comment 0 have `14.16.27023`; not sure about version numbering here but maybe this is "version 14" which is less than "version 16". Tyson, not sure if comment 0 was your local machine vs. some infrastructure in the cloud; either way, I wonder if you know what MSVC version we're using? The best fix here is probably to install updates to pick up the fix noted in the blog post above, if we can do that. I think we're safe to call this INVALID as a Firefox bug, though feel free to reopen if there's code changes we do in fact need to make here.
A Google search for "UBSan Regex" turns up this blog post from 2020: https://devblogs.microsoft.com/cppblog/c20-features-and-fixes-in-vs-2019-16-1-through-16-6/ ...which mentions the following issue as being fixed in Visual Studio 2019 16.4: > Explicitly specified the underlying types of some enumeration types in <regex> that use bitwise operations to avoid storing an unrepresentable value (which is formally undefined behavior, as noted by Clang’s UBSAN). That sounds like an exact match for what I described in comment 2. So: hooray, it's fixed upstream, as of 2020! Presumably we're building with an older MSVC here (I see the paths in comment 0 have `14.16.27023`; not sure about version numbering here but maybe this is "version 14" which is less than "version 16" from the blog post?) Tyson, not sure if comment 0 was your local machine vs. some infrastructure in the cloud; either way, I wonder if you know what MSVC version we're using? The best fix here is probably to install updates to pick up the fix noted in the blog post above, if we can do that. I think we're safe to call this INVALID as a Firefox bug, though feel free to reopen if there's code changes we do in fact need to make here.