Bug 1793807 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Kelly Cochrane [:kcochrane] from comment #15)
> Josh, we've been discussing this some more, and think we could have dismissed tabs work similarly to dismissing Top Sites on the New Tab page. It creates a hash and adds it to a more permanent block list (accessible via browser.newtabpage.blocked in about:config). Previously dismissed tabs would then no longer reappear in the Tab Pickup list regardless of if they visited the same full url at a later time on their other device. Mardak has addressed some potential concerns with this route above, but I think we'll eventually want to give users a way to display a more complete list of synced tabs rather than 3 which would prevent the need to dismiss through tabs until you find the one you're looking for. We may even want to give them a way to "undo" dismissing certain tabs if we take this more permanent block list route.

For additional context, through some code discovery Gijs found out that Fenix doesn't appear to temporarily hide dismissed Sync tabs, so doing it the way Kelly suggested would align with how Fenix dismisses synced tabs (although I think the language there is "Remove").
(In reply to Kelly Cochrane [:kcochrane] from comment #15)
> Josh, we've been discussing this some more, and think we could have dismissed tabs work similarly to dismissing Top Sites on the New Tab page. It creates a hash and adds it to a more permanent block list (accessible via browser.newtabpage.blocked in about:config). Previously dismissed tabs would then no longer reappear in the Tab Pickup list regardless of if they visited the same full url at a later time on their other device. Mardak has addressed some potential concerns with this route above, but I think we'll eventually want to give users a way to display a more complete list of synced tabs rather than 3 which would prevent the need to dismiss through tabs until you find the one you're looking for. We may even want to give them a way to "undo" dismissing certain tabs if we take this more permanent block list route.

For additional context, through some code discovery Gijs found out that Fenix doesn't appear to temporarily hide dismissed Sync tabs, so doing it the way Kelly suggested would align with how Fenix dismisses synced tabs (although I think the language there is "Remove"). Also Markh from the sync team might have thoughts here.

Back to Bug 1793807 Comment 16