Bug 1794238 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to uiy12345 from comment #7)
> I would expect that all that would be done is the source would be saved as it is shown along with all the resources the page uses

This means rewriting the source to refer to the downloaded resources, and fetching those resources to the locations referred to

> (and hence if they are blocked it is not using them and doesn't have to be downloaded and so no error).

The 20-or-so-year-old code makes no attempt to work out "did this script [or img/frame/whatever] tag actually get downloaded successfully".

Even if it did, it might come to the wrong conclusion - it would depend entirely on distinguishing "blocked" from "network failure", which especially with network-based blockers isn't actually a trivial problem to solve.

As always, "just" fixing this to behave the way "most people will agree" it should work is harder than it may appear at first glance.
(In reply to uiy12345 from comment #7)
> I would expect that all that would be done is the source would be saved as it is shown along with all the resources the page uses

This means rewriting the source to refer to the downloaded resources, and fetching those resources to the locations referred to

> (and hence if they are blocked it is not using them and doesn't have to be downloaded and so no error).

The 20-or-so-year-old code makes no attempt to work out "did this script [or img/frame/whatever] tag actually get downloaded successfully [and therefore should I save a copy]".

Even if it did, it might come to the wrong conclusion - it would depend entirely on distinguishing "blocked" from "network failure", which especially with network-based blockers isn't actually a trivial problem to solve.

As always, "just" fixing this to behave the way "most people will agree" it should work is harder than it may appear at first glance.

Back to Bug 1794238 Comment 8