Bug 1797815 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
For Bug 1780441 we are moving away from having our tests open `about:firefoxview` in a regular tab and instead standardizing on using the [`withFirefoxView` helper](https://searchfox.org/mozilla-central/source/browser/components/firefoxview/tests/browser/head.js#180). This more closely reflects how users actually open/interact with Firefox View.

It looks like a lot of the callout tests use `BrowserTestUtils.withNewTab` to open Firefox View in a tab in the current browser. These should also be updated to use the `withFirefoxView` helper, or something that uses similar mechanics to open the tab. 

If using `withFirefoxView` it seems likely that `browser.firefox-view.view-count` will have to get set/reset for each test as it [gets incremented](https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#10042-10050) when the fx view tabstrip button is clicked. (That might be obvious, but when I naively attempted to update some callout tests I was surprised that the fourth test to run always failed).
Revision 1 by
on 
For Bug 1780441 we are moving away from having our tests open `about:firefoxview` in a regular tab and instead standardizing on using the [`withFirefoxView` helper](https://searchfox.org/mozilla-central/source/browser/components/firefoxview/tests/browser/head.js#186). This more closely reflects how users actually open/interact with Firefox View.

It looks like a lot of the callout tests use `BrowserTestUtils.withNewTab` to open Firefox View in a tab in the current browser. These should also be updated to use the `withFirefoxView` helper, or something that uses similar mechanics to open the tab. 

If using `withFirefoxView` it seems likely that `browser.firefox-view.view-count` will have to get set/reset for each test as it [gets incremented](https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#10042-10050) when the fx view tabstrip button is clicked. (That might be obvious, but when I naively attempted to update some callout tests I was surprised that the fourth test to run always failed).

Back to Bug 1797815 Comment 0