Bug 1798493 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #4)
> Note however that there is a bit of messiness where the [algorithm to obtain a storage key](https://storage.spec.whatwg.org/#obtain-a-storage-key) explicitly says "If key’s origin is an opaque origin, then return failure.", but in this case we would be using the null principal internally to correspond to a partitioned origin.  GetStorageKey for an explicit opaque origin with a null principal origin would fail.

Indeed, and https://github.com/w3c/web-locks/pull/75 wants to fix that. I'm not sure how exactly [`to obtain a storage bottle map`](https://storage.spec.whatwg.org/#obtain-a-storage-bottle-map) algorithm maps to our implementation, though.

In any case, we might want to fix the spec first before fixing the implementation.
(In reply to Andrew Sutherland [:asuth] (he/him) from comment #4)
> Note however that there is a bit of messiness where the [algorithm to obtain a storage key](https://storage.spec.whatwg.org/#obtain-a-storage-key) explicitly says "If key’s origin is an opaque origin, then return failure.", but in this case we would be using the null principal internally to correspond to a partitioned origin.  GetStorageKey for an explicit opaque origin with a null principal origin would fail.

Indeed, and https://github.com/w3c/web-locks/pull/75 wants to fix that. I'm not sure how exactly [`to obtain a storage bottle map`](https://storage.spec.whatwg.org/#obtain-a-storage-bottle-map) algorithm maps to our implementation, though.

In any case, we might want to fix the spec first before fixing the implementation.

Edit: Oh wait, I somehow thought you pointed to https://w3c.github.io/web-locks/#obtain-a-lock-manager which has the same step. Meh.

Back to Bug 1798493 Comment 5