Bug 1799613 Comment 25 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: We are persisting width on bookmark dialogs yet, that may cause the dialog to be cut and hide or partially hide one of the buttons

IMPORTANT: only the UPLIFT TO 107 PATCH must be landed in 107, not the patch that landed in Nightly 108, they differ.
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: must test migrating a profile with persisted attributes from 106 to 107, though that requires running scripts in the Browser Console for the most part, to set attributes before, and check they are gone later. 
in 106 `Services.xulStore.setValue("chrome://browser/content/places/bookmarkProperties.xhtml", "bookmarkproperties", "width", "200")`
in 107 `Services.xulStore.getValue("chrome://browser/content/places/bookmarkProperties.xhtml", "bookmarkproperties", "width")` must return an empty string and not "200"
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: it is just removing values from xulstore, it's a trivial ui migration.
* **String changes made/needed**: 
* **Is Android affected?**: No
Revision 1 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: We are persisting width on bookmark dialogs yet, that may cause the dialog to be cut and hide or partially hide one of the buttons

**IMPORTANT: only the UPLIFT TO 107 PATCH must be landed in 107, not the patch that landed in Nightly 108, they differ.**
* **Is this code covered by automated tests?**: No
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: must test migrating a profile with persisted attributes from 106 to 107, though that requires running scripts in the Browser Console for the most part, to set attributes before, and check they are gone later. 
in 106 `Services.xulStore.setValue("chrome://browser/content/places/bookmarkProperties.xhtml", "bookmarkproperties", "width", "200")`
in 107 `Services.xulStore.getValue("chrome://browser/content/places/bookmarkProperties.xhtml", "bookmarkproperties", "width")` must return an empty string and not "200"
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: it is just removing values from xulstore, it's a trivial ui migration.
* **String changes made/needed**: 
* **Is Android affected?**: No

Back to Bug 1799613 Comment 25