Bug 1799747 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Darkspirit from comment #8)
> bug 1756459 should still work for nvidia-vaapi-driver.
> 
> Would something like the following logic at the beginning of [vaapitest()](https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/toolkit/xre/glxtest.cpp#1116) work?
> if [dl_iterate_phdr](https://gist.github.com/kinichiro/66191f27963c9efe25d0) (bug 1804974 comment 2) finds "[..]vdpau_drv_video.so" {
> record_warning("VA-API force-disabled: Please uninstall deprecated libva-vdpau-driver "
>                            "which doesn't support vaGetDisplayDRM and most likely crashes");
> return;
> }
> 
> I assume bug 1804974 occured due to force-enabling: Would force-enabling be reliably prevented by [this code](https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/widget/gtk/GfxInfo.cpp#926-927)?

We may create it as a next iteration of the patch. Right now we can't print available codecs on about:support for NIVIDIA but given it's state I don't think it so big deal.

I'm looking to enable VA-API by default which means we can't generate coredumps on NVIDIA systems. GfxInfo.cpp just reads data from remote process (which crashes on broken NVIDIA), that's not the detection itself.
(In reply to Darkspirit from comment #8)
> bug 1756459 should still work for nvidia-vaapi-driver.
> 
> Would something like the following logic at the beginning of [vaapitest()](https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/toolkit/xre/glxtest.cpp#1116) work?
> if [dl_iterate_phdr](https://gist.github.com/kinichiro/66191f27963c9efe25d0) (bug 1804974 comment 2) finds "[..]vdpau_drv_video.so" {
> record_warning("VA-API force-disabled: Please uninstall deprecated libva-vdpau-driver "
>                            "which doesn't support vaGetDisplayDRM and most likely crashes");
> return;
> }
> 
> I assume bug 1804974 occured due to force-enabling: Would force-enabling be reliably prevented by [this code](https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/widget/gtk/GfxInfo.cpp#926-927)?

We may create it as a next iteration of the patch. Right now we can't print available codecs on about:support for NIVIDIA but given it's state I don't think it's so big deal.

I'm looking to enable VA-API by default which means we can't generate coredumps on NVIDIA systems. GfxInfo.cpp just reads data from remote process (which crashes on broken NVIDIA), that's not the detection itself.

Back to Bug 1799747 Comment 9