Bug 1801419 Comment 59 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Revision 1 by
on 
See bug 1841445 comment #2.

> This isn't really a regression. The same crashes would have happened without my patch, but in a different place in the Mozilla code. Also, the crashes `[@ libsystem_kernel.dylib@0x2972]` are same as those `[@ mig_strncpy_zerofill ]`. The non-symbolicated signature is for a macOS 13.5.0 beta. I only scrape symbols for release versions and betas of the next major release (currently macOS 14).
> 
> Here's a search, copied from bug 1801419 comment #56 and updated, which captures all that bug's crashes for the last month (in builds with my second patch), including those with non-symbolicated signatures:
> 
> https://crash-stats.mozilla.org/search/?proto_signature=~PinSidecarCoreTextCStringSections&platform=Mac%20OS%20X&date=%3E%3D2023-06-03T19%3A26%3A00.000Z&date=%3C2023-07-03T19%3A26%3A00.000Z&_facets=signature&_facets=platform_version&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature
> 
> And here's these stats with the non-symbolicated signatures folded in with the symbolicated ones. Compare them to those from bug 1801419 comment #58.
> 
> ```
> [@ +[NSString stringWithCString:encoding:] ]  200
> [@ mig_strncpy_zerofill ]                      39
> [@ _mapStrHash ]                               12
> [@ prepareMethodLists ]                         7
> ```
> 
> They do seem higher, but that has nothing to do with this bug report.
Revision 2 by
on 
See bug 1841445 comment #2:

> This isn't really a regression. The same crashes would have happened without my patch, but in a different place in the Mozilla code. Also, the crashes `[@ libsystem_kernel.dylib@0x2972]` are same as those `[@ mig_strncpy_zerofill ]`. The non-symbolicated signature is for a macOS 13.5.0 beta. I only scrape symbols for release versions and betas of the next major release (currently macOS 14).
> 
> Here's a search, copied from bug 1801419 comment #56 and updated, which captures all that bug's crashes for the last month (in builds with my second patch), including those with non-symbolicated signatures:
> 
> https://crash-stats.mozilla.org/search/?proto_signature=~PinSidecarCoreTextCStringSections&platform=Mac%20OS%20X&date=%3E%3D2023-06-03T19%3A26%3A00.000Z&date=%3C2023-07-03T19%3A26%3A00.000Z&_facets=signature&_facets=platform_version&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature
> 
> And here's these stats with the non-symbolicated signatures folded in with the symbolicated ones. Compare them to those from bug 1801419 comment #58.
> 
> ```
> [@ +[NSString stringWithCString:encoding:] ]  200
> [@ mig_strncpy_zerofill ]                      39
> [@ _mapStrHash ]                               12
> [@ prepareMethodLists ]                         7
> ```
> 
> They do seem higher, but that has nothing to do with this bug report.

Back to Bug 1801419 Comment 59