Bug 1801819 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)
> Jens, could you check if anything needs to be done for the [crashes with this signature](https://crash-stats.mozilla.org/signature/?product=Firefox&signature=shutdownhang%20%7C%20PlatformThread%3A%3AJoin&date=%3E%3D2022-11-15T09%3A16%3A00.000Z&date=%3C2022-11-22T09%3A16%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=moz_crash_reason&_sort=-date&page=2#summary) in general?

It would be nice if we could bucket them by the first stack frame called by `ShutdownXPCOM`. For [example here](https://crash-stats.mozilla.org/report/index/712687a3-aaf0-4130-9638-474420221122) it would be `nsComponentManagerImpl::Shutdown()` (ok, we would not know which component, but still), [here](https://crash-stats.mozilla.org/report/index/19881c77-1629-40b7-9b5c-1866e0221122) it'd be `gfxPlatform::ShutdownLayersIPC()` (would contain the WinWindowOcclusionTracker case) and so forth.
Revision 1 by
on 
(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)
> Jens, could you check if anything needs to be done for the [crashes with this signature](https://crash-stats.mozilla.org/signature/?product=Firefox&signature=shutdownhang%20%7C%20PlatformThread%3A%3AJoin&date=%3E%3D2022-11-15T09%3A16%3A00.000Z&date=%3C2022-11-22T09%3A16%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=moz_crash_reason&_sort=-date&page=2#summary) in general?

It would be nice if we could bucket them by the first stack frame called by `ShutdownXPCOM`. For [example here](https://crash-stats.mozilla.org/report/index/712687a3-aaf0-4130-9638-474420221122) it would be `nsComponentManagerImpl::Shutdown()` (ok, we would not know which component, but still), [here](https://crash-stats.mozilla.org/report/index/19881c77-1629-40b7-9b5c-1866e0221122) it'd be `gfxPlatform::ShutdownLayersIPC()` (would contain the WinWindowOcclusionTracker case) and so forth.

Hmm, or we could bucket by the frames that actually call `base::Thread::Stop()` ? That would give us probably the most details and a direct pointer to the thread in questions.
Revision 2 by
on 
(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)
> Jens, could you check if anything needs to be done for the [crashes with this signature](https://crash-stats.mozilla.org/signature/?product=Firefox&signature=shutdownhang%20%7C%20PlatformThread%3A%3AJoin&date=%3E%3D2022-11-15T09%3A16%3A00.000Z&date=%3C2022-11-22T09%3A16%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=moz_crash_reason&_sort=-date&page=2#summary) in general?

It would be nice if we could bucket them by the first stack frame called by `ShutdownXPCOM`. For [example here](https://crash-stats.mozilla.org/report/index/712687a3-aaf0-4130-9638-474420221122) it would be `nsComponentManagerImpl::Shutdown()` (ok, we would not know which component, but still), [here](https://crash-stats.mozilla.org/report/index/19881c77-1629-40b7-9b5c-1866e0221122) it'd be `gfxPlatform::ShutdownLayersIPC()` (would contain the WinWindowOcclusionTracker case) and so forth.

Hmm, or we could bucket by the frames that actually call `base::Thread::Stop()` ? That would give us probably the most details and a direct pointer to the thread in questions. In the first example that would be `D3DVsyncSource::Shutdown()`.
Revision 3 by
on 
(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)
> Jens, could you check if anything needs to be done for the [crashes with this signature](https://crash-stats.mozilla.org/signature/?product=Firefox&signature=shutdownhang%20%7C%20PlatformThread%3A%3AJoin&date=%3E%3D2022-11-15T09%3A16%3A00.000Z&date=%3C2022-11-22T09%3A16%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=moz_crash_reason&_sort=-date&page=2#summary) in general?

It would be nice if we could bucket them by the first stack frame called by `ShutdownXPCOM`. For [example here](https://crash-stats.mozilla.org/report/index/712687a3-aaf0-4130-9638-474420221122) it would be `nsComponentManagerImpl::Shutdown()` (ok, we would not know which component, but still), [here](https://crash-stats.mozilla.org/report/index/19881c77-1629-40b7-9b5c-1866e0221122) it'd be `gfxPlatform::ShutdownLayersIPC()` (would contain the WinWindowOcclusionTracker case) and so forth.

Hmm, or we could bucket by the frames that actually call `base::Thread::Stop()` ? That would give us probably the most details and a direct pointer to the thread in question. In the first example that would be `D3DVsyncSource::Shutdown()`.

Back to Bug 1801819 Comment 3