Bug 1802466 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Narcis Beleuzu [:NarcisB] from comment #16)
> Please also check :
> WPT failure on [text-input-vertical-overflow-no-scroll.html](https://treeherder.mozilla.org/logviewer?job_id=428173252&repo=autoland&lineNumber=2663)

That's the test I'm fixing here. It looks like we're still triggering bug 1851066 there (it's an off-by-1px scrollTop test failure).

We can just annotate it as expected-fail on Android for now, I suppose.

The other failures are due to a typo that I made when addressing a review comment (whoops).  I was able to reproduce the text failure in test_composition_text_querycontent.xhtml (the test mentioned in comment 14) locally, and then after fixing the typo, I can't reproduce any issues in that or the other failing tests locally. So I think those are all set with the typo fixed.
(In reply to Narcis Beleuzu [:NarcisB] from comment #16)
> Please also check :
> WPT failure on [text-input-vertical-overflow-no-scroll.html](https://treeherder.mozilla.org/logviewer?job_id=428173252&repo=autoland&lineNumber=2663)

That's the test I'm fixing here. It looks like we're still triggering bug 1851066 there (it's an off-by-1px scrollTop test failure).

We can just annotate it as expected-fail on Android for now, I suppose.  I don't want to add further hacks to that test just for an Android-specific issue, since it's in the common WPT repo.

The other failures are due to a typo that I made when addressing a review comment (whoops).  I was able to reproduce the text failure in test_composition_text_querycontent.xhtml (the test mentioned in comment 14) locally, and then after fixing the typo, I can't reproduce any issues in that or the other failing tests locally. So I think those are all set with the typo fixed.
(In reply to Narcis Beleuzu [:NarcisB] from comment #16)
> Please also check :
> WPT failure on [text-input-vertical-overflow-no-scroll.html](https://treeherder.mozilla.org/logviewer?job_id=428173252&repo=autoland&lineNumber=2663)

That's the test I'm fixing here. It looks like we're still triggering bug 1851066 there (the failure log shows an off-by-1px scrollTop test failure).

We can just annotate it as expected-fail on Android for now, I suppose.  I don't want to add further hacks to that test just for an Android-specific issue, since it's in the common WPT repo.

The other failures are due to a typo that I made when addressing a review comment (whoops).  I was able to reproduce the text failure in test_composition_text_querycontent.xhtml (the test mentioned in comment 14) locally, and then after fixing the typo, I can't reproduce any issues in that or the other failing tests locally. So I think those are all set with the typo fixed.

Back to Bug 1802466 Comment 17