Bug 1802834 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

We explicitly ask explorer to open the file. If it's helpful for the NoMachine devs, our code is obviously open source and can also be searched/explorer on the web without making a local build etc. I think the relevant code is https://searchfox.org/mozilla-central/rev/2d24d893669ad0fe8d76b0427b25369d35fcc19b/uriloader/exthandler/win/nsMIMEInfoWin.cpp#69-76 , which calls this method: https://searchfox.org/mozilla-central/rev/2d24d893669ad0fe8d76b0427b25369d35fcc19b/widget/windows/ShellHeaderOnlyUtils.h#48 . If opening via explorer fails, we fall back to doing it ourselves - and in that case I could believe that somehow sandboxing on Firefox would break something (see also the comments on the first file around why we try to open via explorer in the first place).

Molly, I don't suppose you're in a position to try to repro/diagnose what could be going wrong in the interaction with this installer and `ShellExecuteByExplorer` ?
We explicitly ask explorer to open the file. If it's helpful for the NoMachine devs, our code is obviously open source and can also be searched/explored on the web without making a local build etc. I think the relevant code is https://searchfox.org/mozilla-central/rev/2d24d893669ad0fe8d76b0427b25369d35fcc19b/uriloader/exthandler/win/nsMIMEInfoWin.cpp#69-76 , which calls this method: https://searchfox.org/mozilla-central/rev/2d24d893669ad0fe8d76b0427b25369d35fcc19b/widget/windows/ShellHeaderOnlyUtils.h#48 . If opening via explorer fails, we fall back to doing it ourselves - and in that case I could believe that somehow sandboxing on Firefox would break something (see also the comments on the first file around why we try to open via explorer in the first place).

Molly, I don't suppose you're in a position to try to repro/diagnose what could be going wrong in the interaction with this installer and `ShellExecuteByExplorer` ?

Back to Bug 1802834 Comment 5