Bugzilla

I'd like to come up with an actionable plan to solve this problem, and hopefully unblock these linting/formatting patches. This is what I propose:

- Turn off Lando autoformatting
- Patches currently blocked by this bug can be landed.
- Implement a fix for this issue in our in-tree formatters*.
- Make any changes to Lando required to take the fix.
- Re-enable Lando autoformatting.

*There have been a few suggestions for what the "fix" should be, either:

- Make `mach lint` avoid checking the entire tree when `support-file` is touched if `--fix` is passed.
- Implement `mach format` as a command that only runs formatters and is not an alias to `mach lint --fix`, where the latter can potentially fix non-formatting issues.

:ahal, :marco, what would your preferred solution be here? Making the tree-wide lint not take place with `--fix` is present is probably the quickest fix, but a few folks have expressed interest in `mach format` or similar that only applies formatting fixes. Whatever the solution I would be happy to implement it with some guidance.

I'd like to come up with an actionable plan to solve this problem, and hopefully unblock these linting/formatting patches. This is what I propose:

- Turn off Lando autoformatting.
- Patches currently blocked by this bug can be landed.
- Implement a fix for this issue in our in-tree formatters*.
- Make any changes to Lando required to take the fix.
- Re-enable Lando autoformatting.

*There have been a few suggestions for what the "fix" should be, either:

- Make `mach lint` avoid checking the entire tree when `support-file` is touched if `--fix` is passed.
- Implement `mach format` as a command that only runs formatters and is not an alias to `mach lint --fix`, where the latter can potentially fix non-formatting issues.

:ahal, :marco, what would your preferred solution be here? Making the tree-wide lint not take place with `--fix` is present is probably the quickest fix, but a few folks have expressed interest in `mach format` or similar that only applies formatting fixes. Whatever the solution I would be happy to implement it with some guidance.