Bug 1804166 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Tim Giles [:tgiles] from comment #9)
> How I would recommend verifying is by doing the following:
> 1. Go to settings and change New Tab to Blank Page
> 2. Open a new tab and go to google.com
> 3. Open the browser toolbox and put a breakpoint on that line I mentioned earlier in this comment
> 4. Change the google.com tab to about:newtab

I'm a bit confused here; my understanding is that even with the Blank Page setting, new tabs will still use `about:newtab` which would then point to a blank page. So if none of the above steps involve about:blank, why does your potential solution involve adding that to `FAVICON_DEFAULTS`?
(In reply to Tim Giles [:tgiles] from comment #9)
> How I would recommend verifying is by doing the following:
> 1. Go to settings and change New Tab to Blank Page
> 2. Open a new tab and go to google.com
> 3. Open the browser toolbox and put a breakpoint on that line I mentioned earlier in this comment
> 4. Change the google.com tab to about:newtab

I'm a bit confused here; my understanding is that even with the Blank Page setting, new tabs will still use `about:newtab` which would then point to a blank page. So if none of the above steps involve `about:blank`, why does your potential solution involve adding that to `FAVICON_DEFAULTS`?

Back to Bug 1804166 Comment 14