Bug 1804974 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
> 10 	vdpau_drv_video.so 	__vaDriverInit_1_15 	/usr/src/debug/libva-vdpau-driver-0.7.4-7.10.x86_64/src/vdpau_driver.c:317

We don't want to run this code.
IIRC legacy dri2 wants an X11 cookie while dri3 works with an fd.
vaGetDisplayDRM uses dri3 (bug 1580166 comment 6).

vdpau_drv_video.so background:
Deprecated libva-vdpau-driver doesn't support vaGetDisplayDRM and crashes.
Therefore the VAAPI test has been moved into the glxtest process  (bug 1787182, bug 1758473/bug 1758473) to disable VAAPI in case vdpau_drv_video.so is present.

Could a sandbox rule just block vdpau_drv_video.so from being loaded in RDD and glxtest?

(Darkspirit from bug 1758473 comment #9)
> It might be this one: https://salsa.debian.org/multimedia-team/attic/vdpau-video/-/blob/63450ffea86143d418c6e83cb8d2828d3a7beb25/src/vdpau_driver.c#L188
> > const char * const x11_dpy_name = XDisplayString(driver_data->x11_dpy);
> 
> https://bugs.archlinux.org/task/72241#comments
> >  vaGetDisplayDRM() doesn't fill ->x11_dpy
> 
> VAAPI should be blocked for vdpau_drv_video.so.
> vdpau_drv_video.so is deprecated and has been removed from Debian.
> Debian Buster (oldstable) was the last release that had a package for it: https://packages.debian.org/oldstable/vdpau-va-driver
> https://tracker.debian.org/pkg/vdpau-video
> https://salsa.debian.org/multimedia-team/attic/vdpau-video
Revision 1 by
on 
> 10 	vdpau_drv_video.so 	__vaDriverInit_1_15 	/usr/src/debug/libva-vdpau-driver-0.7.4-7.10.x86_64/src/vdpau_driver.c:317

We don't want to run this code.
IIRC legacy dri2 wants an X11 auth cookie while dri3 works with an fd.
vaGetDisplayDRM uses dri3 (bug 1580166 comment 6).

vdpau_drv_video.so background:
Deprecated libva-vdpau-driver doesn't support vaGetDisplayDRM and crashes.
Therefore the VAAPI test has been moved into the glxtest process  (bug 1787182, bug 1758473/bug 1758473) to disable VAAPI in case vdpau_drv_video.so is present.

Could a sandbox rule just block vdpau_drv_video.so from being loaded in RDD and glxtest?

(Darkspirit from bug 1758473 comment #9)
> It might be this one: https://salsa.debian.org/multimedia-team/attic/vdpau-video/-/blob/63450ffea86143d418c6e83cb8d2828d3a7beb25/src/vdpau_driver.c#L188
> > const char * const x11_dpy_name = XDisplayString(driver_data->x11_dpy);
> 
> https://bugs.archlinux.org/task/72241#comments
> >  vaGetDisplayDRM() doesn't fill ->x11_dpy
> 
> VAAPI should be blocked for vdpau_drv_video.so.
> vdpau_drv_video.so is deprecated and has been removed from Debian.
> Debian Buster (oldstable) was the last release that had a package for it: https://packages.debian.org/oldstable/vdpau-va-driver
> https://tracker.debian.org/pkg/vdpau-video
> https://salsa.debian.org/multimedia-team/attic/vdpau-video
Revision 2 by
on 
> 10 	vdpau_drv_video.so 	__vaDriverInit_1_15 	/usr/src/debug/libva-vdpau-driver-0.7.4-7.10.x86_64/src/vdpau_driver.c:317

We don't want to run this code.
IIRC legacy dri2 wants an X11 auth cookie while dri3 works with an fd.
vaGetDisplayDRM uses dri3 (bug 1580166 comment 6).

vdpau_drv_video.so background:
Deprecated libva-vdpau-driver doesn't support vaGetDisplayDRM and crashes.
Therefore the VAAPI test has been moved into the glxtest process  (bug 1787182, bug 1758473/bug 1777927) to disable VAAPI in case vdpau_drv_video.so is present.

Could a sandbox rule just block vdpau_drv_video.so from being loaded in RDD and glxtest?

(Darkspirit from bug 1758473 comment #9)
> It might be this one: https://salsa.debian.org/multimedia-team/attic/vdpau-video/-/blob/63450ffea86143d418c6e83cb8d2828d3a7beb25/src/vdpau_driver.c#L188
> > const char * const x11_dpy_name = XDisplayString(driver_data->x11_dpy);
> 
> https://bugs.archlinux.org/task/72241#comments
> >  vaGetDisplayDRM() doesn't fill ->x11_dpy
> 
> VAAPI should be blocked for vdpau_drv_video.so.
> vdpau_drv_video.so is deprecated and has been removed from Debian.
> Debian Buster (oldstable) was the last release that had a package for it: https://packages.debian.org/oldstable/vdpau-va-driver
> https://tracker.debian.org/pkg/vdpau-video
> https://salsa.debian.org/multimedia-team/attic/vdpau-video

Back to Bug 1804974 Comment 1