Bug 1805915 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

False alarm about the mappings - the ranges look fine. I forgot that unsymbolicated functions still display the absolute addresses, not the relative addresses. Their internal relative address values look reasonable. For example, one of the hottest addresses is 0xadc73be, which symbolicates fine:

```
query_api % cargo run -- ~/Downloads/ /symbolicate/v5 '{"jobs":[{"memoryMap":[["mold-opt-libxul.so","36D208789F8DF932F8E647CB2BE1FAE60"]],"stacks":[[[0,182219710]]]}]}' | jq  
{
  "results": [
    {
      "stacks": [
        [
          {
            "frame": 0,
            "module_offset": "0xadc73be",
            "module": "mold-opt-libxul.so",
            "function": "style::dom_apis::query_selector",
            "function_offset": "0xebe",
            "function_size": "0x171a",
            "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
            "line": 642,
            "inlines": [
              {
                "function": "<style::gecko::wrapper::GeckoNode as style::dom::TNode>::as_element",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/gecko/wrapper.rs",
                "line": 479
              },
              {
                "function": "style::dom_apis::collect_all_elements",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 230
              },
              {
                "function": "style::dom_apis::query_selector_single_query",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 397
              },
              {
                "function": "style::dom_apis::query_selector_fast",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 448
              }
            ]
          }
        ]
      ],
      "found_modules": {
        "mold-opt-libxul.so/36D208789F8DF932F8E647CB2BE1FAE60": true
      }
    }
  ]
}
```
False alarm about the mappings - the ranges look fine. I forgot that unsymbolicated functions in the profiler still display the absolute addresses, not the relative addresses. Their internal relative address values look reasonable. For example, one of the hottest addresses is 0xadc73be, which symbolicates fine:

```
query_api % cargo run -- ~/Downloads/ /symbolicate/v5 '{"jobs":[{"memoryMap":[["mold-opt-libxul.so","36D208789F8DF932F8E647CB2BE1FAE60"]],"stacks":[[[0,182219710]]]}]}' | jq  
{
  "results": [
    {
      "stacks": [
        [
          {
            "frame": 0,
            "module_offset": "0xadc73be",
            "module": "mold-opt-libxul.so",
            "function": "style::dom_apis::query_selector",
            "function_offset": "0xebe",
            "function_size": "0x171a",
            "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
            "line": 642,
            "inlines": [
              {
                "function": "<style::gecko::wrapper::GeckoNode as style::dom::TNode>::as_element",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/gecko/wrapper.rs",
                "line": 479
              },
              {
                "function": "style::dom_apis::collect_all_elements",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 230
              },
              {
                "function": "style::dom_apis::query_selector_single_query",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 397
              },
              {
                "function": "style::dom_apis::query_selector_fast",
                "file": "/home/emilio/src/moz/gecko/servo/components/style/dom_apis.rs",
                "line": 448
              }
            ]
          }
        ]
      ],
      "found_modules": {
        "mold-opt-libxul.so/36D208789F8DF932F8E647CB2BE1FAE60": true
      }
    }
  ]
}
```

Back to Bug 1805915 Comment 8