Bug 1807073 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I can reproduce the issue and seems like it is stemming from GeckoView - see the missing edge glow that GeckoView controls and does not show when the pull to refresh throbber shows. Checking the data that we sync on with GeckoView I see that in that case the `InputResultDetail` API sends us the same data as when the gesture should be enabled (same as for the expected scenario - dragging the wikipedia page down from the very top in one continuous gesture):
- `inputResult` == `INPUT_HANDLING_UNKNOWN`
- `scrolLDirections` == `SCROLL_DIRECTIONS_TOP` 
- `overscrollDirections` == `OVERSCROLL_DIRECTIONS_VERTICAL`

That would mean that if we are to ignore `INPUT_HANDLING_UNKNOWN` here[1] then pull to refresh would not have the issue described in this ticket but it would also not work in the expected scenario. And the glow effect would also not be showing.

cc Botond for recommendations since we're in an active process of polishing the feature.
I can reproduce the issue and seems like it is stemming from GeckoView - see the missing edge glow that GeckoView controls and does not show when the pull to refresh throbber shows. Checking the data that we sync on with GeckoView I see that in that case the `InputResultDetail` API sends us the same data as when the gesture should be enabled (same as for the expected scenario - dragging the wikipedia page down from the very top in one continuous gesture):
- `inputResult` == `INPUT_HANDLING_UNKNOWN`
- `scrolLDirections` == `SCROLL_DIRECTIONS_TOP` 
- `overscrollDirections` == `OVERSCROLL_DIRECTIONS_VERTICAL`

That would mean that if we are to ignore `INPUT_HANDLING_UNKNOWN` here[1] then pull to refresh would not have the issue described in this ticket but it would also not work in the expected scenario. And the glow effect would also not be showing.

cc Botond for recommendations since we're in an active process of polishing the feature.

[1] https://searchfox.org/mozilla-mobile/rev/4c640a0da38ce181ea89e71d20b90a7f881d65b9/firefox-android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/InputResultDetail.kt#258-261
I can reproduce the issue and seems like it is stemming from GeckoView - see the missing edge glow that GeckoView controls and does not show when the pull to refresh throbber shows. Checking the data that we sync on with GeckoView I see that in that case the `InputResultDetail` API sends us the same data as when the gesture should be enabled (same as for the expected scenario - dragging the wikipedia page down from the very top in one continuous gesture):
- `inputResult` == `INPUT_HANDLING_UNKNOWN`
- `scrolLDirections` == `SCROLL_DIRECTIONS_NONE` 
- `overscrollDirections` == `OVERSCROLL_DIRECTIONS_VERTICAL`

That would mean that if we are to ignore `INPUT_HANDLING_UNKNOWN` here[1] then pull to refresh would not have the issue described in this ticket but it would also not work in the expected scenario. And the glow effect would also not be showing.

cc Botond for recommendations since we're in an active process of polishing the feature.

[1] https://searchfox.org/mozilla-mobile/rev/4c640a0da38ce181ea89e71d20b90a7f881d65b9/firefox-android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/InputResultDetail.kt#258-261

Back to Bug 1807073 Comment 4