Bug 1809115 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
> I think what you're seeing in that page is most likely bug 1901515.

Not sure if bug 1901515 is supposed to change that, too, but in that profile I also see many direct destructions (free) of `nsIFrame` derived things which I [would have expected to happen later looking here](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/base/PresShell.h#289-292) as we are probably seeing a `mIsDestroying` case? But maybe I miss quite a lot here.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
> I think what you're seeing in that page is most likely bug 1901515.

Not sure if bug 1901515 is supposed to change that, too, but in that profile I also see many direct destructions (free) of `nsIFrame` derived things which I [would have expected to happen later looking here](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/base/PresShell.h#289-292) as we are probably seeing a `mIsDestroying` case? But maybe I miss quite a lot here, those might be other things held by those objects, too.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
> I think what you're seeing in that page is most likely bug 1901515.

Not sure if bug 1901515 is supposed to change that, too, but in that profile I also see many direct destructions (free) of `nsIFrame` derived things which I [would have expected to happen later looking here](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/base/PresShell.h#289-292) as we are probably seeing a `mIsDestroying` case? But maybe I miss quite a lot here, those might be other things held by those objects, too.

Edit: Ah, [running destructors does not necessarily mean we free the memory](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/generic/nsIFrame.cpp#894) and it seems those destructor runs cost us some time.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
> I think what you're seeing in that page is most likely bug 1901515.

Not sure if bug 1901515 is supposed to change that, too, but in that profile I also see many direct destructions (~~free~~) of `nsIFrame` derived things which I [would have expected to happen later looking here](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/base/PresShell.h#289-292) as we are probably seeing a `mIsDestroying` case? But maybe I miss quite a lot here, those might be other things held by those objects, too.

Edit: Ah, [running destructors does not necessarily mean we free the memory](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/generic/nsIFrame.cpp#894) and it seems those destructor runs cost us some time.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
> I think what you're seeing in that page is most likely bug 1901515.

Not sure if bug 1901515 is supposed to change that, too, but in that profile I also see many direct destructions (~~free~~) of `nsIFrame` derived things which I [would have expected to happen later looking here](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/base/PresShell.h#289-292) as we are probably seeing a `mIsDestroying` case? But maybe I miss quite a lot here, those might be other things held by those objects, too.

Edit: Ah, [running destructors does not necessarily mean we free the memory](https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/layout/generic/nsIFrame.cpp#894) and it seems those destructor runs cost us some time. Still I see the memory decreasing quite a lot while `nsFrameManager::Destroy` runs before we get to the actual `nsDocumentViewer::DestroyPresShell`.

Back to Bug 1809115 Comment 10