I can reproduce the failure `this._internal._createRecentTabsList is not a function - stack: getRecentTabs@resource://services-sync/SyncedTabs.sys.mjs:327:27 ` if I run all of `browser/components/firefoxview/tests/browser` and `browser/components/firefoxview/tests/browser` but I've not yet been able to reduce it down any further. The firefoxview tests do stub `SyncedTabs` methods, but we don't ever touch `SyncedTabs._internal`. Several of the urlbar tests replace `SyncedTabs._internal` with a mock and restore the original in a `registerCleanupFunction` function. So presumably something in my patch affecting the timing? Or changing some state in a way that causes these to fail later in the same test run? In this [try push](https://treeherder.mozilla.org/jobs?repo=try&revision=ab8d9cd7bdd68f20f9890f9f9dceccd108d2f33b), I added an assertion in a registerCleanupFunction to ensure `this._internal._createRecentTabsList` *is* a function at the end of each firefoxview test. and that seems to be the case. Yet, just a couple of tests into the urlbar suite, `browser_searchMode_excludeResults.js` again fails saying `_createRecentTabsList` isn't a function. I'm missing something...
Bug 1809661 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I can reproduce the failure `this._internal._createRecentTabsList is not a function - stack: getRecentTabs@resource://services-sync/SyncedTabs.sys.mjs:327:27 ` if I run all of `browser/components/firefoxview/tests/browser` and `browser/components/firefoxview/tests/browser` but I've not yet been able to reduce it down any further. The firefoxview tests do stub `SyncedTabs` methods, but we don't ever touch `SyncedTabs._internal`. Several of the urlbar tests replace `SyncedTabs._internal` with a mock and restore the original in a `registerCleanupFunction` function. So presumably something in my patch affecting the timing? Or changing some state in a way that causes these to fail later in the same test run? In this [try push](https://treeherder.mozilla.org/jobs?repo=try&revision=ab8d9cd7bdd68f20f9890f9f9dceccd108d2f33b), I added an assertion in a registerCleanupFunction to ensure `SyncedTabs._internal._createRecentTabsList` *is* a function at the end of each firefoxview test. and that seems to be the case. Yet, just a couple of tests into the urlbar suite, `browser_searchMode_excludeResults.js` again fails saying `_createRecentTabsList` isn't a function. I'm missing something...