Bug 1811746 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

It seems we can find our process still subscribed to the given `BrowsingContextGroup` despite having started our content process' shutdown. IIUC, we always will `ContentParent::MarkAsDead` and thus `ContentParent::RemoveFromList` where we unsubscribe the process from all `mGroups`, so this is not really expected, unless there is some misalignment in our book-keeping for `BrowsingContextGroup`s between what the `ContentParent` knows about it and who else might reference them.

I assume we could just [check for `!contentParent->IsShuttingDown()` here](https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/dom/ipc/ContentParent.cpp#1065) to paint over this here but it feels wrong that those `BrowsingContextGroup` still refer to an apparently dying process?
It seems we can find our process still subscribed to the given `BrowsingContextGroup` despite having started our content process' shutdown. IIUC, we always will `ContentParent::MarkAsDead` and thus `ContentParent::RemoveFromList` where we unsubscribe the process from all `mGroups` when we have done `SignalImpendingShutdownToContentJS`, so this is not really expected, unless there is some misalignment in our book-keeping for `BrowsingContextGroup`s between what the `ContentParent` knows about it and who else might reference them.

I assume we could just [check for `!contentParent->IsShuttingDown()` here](https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/dom/ipc/ContentParent.cpp#1065) to paint over this here but it feels wrong that those `BrowsingContextGroup` still refer to an apparently dying process?
It seems we can find our process still subscribed to the given `BrowsingContextGroup` despite having started our content process' shutdown. IIUC, we always will `ContentParent::MarkAsDead` and thus `ContentParent::RemoveFromList` where we unsubscribe the process from all `mGroups` at the same time when we have done `SignalImpendingShutdownToContentJS`, so this is not really expected, unless there is some misalignment in our book-keeping for `BrowsingContextGroup`s between what the `ContentParent` knows about it and who else might reference them.

I assume we could just [check for `!contentParent->IsShuttingDown()` here](https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/dom/ipc/ContentParent.cpp#1065) to paint over this here but it feels wrong that those `BrowsingContextGroup` still refer to an apparently dying process?

Back to Bug 1811746 Comment 3